[Discover] Remove services from component dependencies #121691
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dimaanj
added
Feature:Discover
dimaanj
added
the
technical debt
…services-from-component-props # Conflicts: # src/plugins/discover/public/application/main/components/sidebar/__snapshots__/discover_index_pattern_management.test.tsx.snap
|
@elasticmachine merge upstream |
|
Pinging @elastic/kibana-data-discovery (Team:DataDiscovery) |
kertal
reviewed
Jan 4, 2022
…services-from-component-props # Conflicts: # src/plugins/discover/public/application/context/context_app_content.tsx # src/plugins/discover/public/application/main/components/field_stats_table/field_stats_table.tsx # src/plugins/discover/public/application/main/components/field_stats_table/field_stats_table_saved_search_embeddable.tsx # src/plugins/discover/public/application/main/components/layout/discover_layout.test.tsx # src/plugins/discover/public/application/main/components/sidebar/__snapshots__/discover_index_pattern_management.test.tsx.snap # src/plugins/discover/public/application/main/components/sidebar/discover_index_pattern_management.tsx # src/plugins/discover/public/application/main/components/sidebar/discover_sidebar.tsx # src/plugins/discover/public/embeddable/saved_search_embeddable.tsx # src/plugins/discover/public/embeddable/saved_search_grid.tsx
|
@elasticmachine merge upstream |
|
@elasticmachine merge upstream |
kertal
reviewed
Jan 18, 2022
dimaanj
commented
Jan 21, 2022
…services-from-component-props # Conflicts: # src/plugins/discover/public/application/main/components/chart/discover_chart.tsx # src/plugins/discover/public/components/discover_grid/get_render_cell_value.tsx
|
@elasticmachine merge upstream |
kertal
reviewed
Jan 25, 2022
src/plugins/discover/public/application/main/components/top_nav/open_search_panel.test.tsx
Outdated
Show resolved
Hide resolved
kertal
reviewed
Jan 25, 2022
src/plugins/discover/public/components/discover_grid/discover_grid.test.tsx
Outdated
Show resolved
Hide resolved
…grid.test.tsx Co-authored-by: Matthias Wilhelm <[email protected]>
kertal
reviewed
Jan 26, 2022
There was a problem hiding this comment.
This is a huge PR in every way, kudos @dmitriynj for simplifying our future life (might cause a few curses when back porting tough). Tested and works as expected. Found 2 more things in the code review, then it should be good to merge
|
@elasticmachine merge upstream |
…services-from-component-props # Conflicts: # src/plugins/discover/public/application/main/discover_main_route.tsx # src/plugins/discover/public/components/discover_grid/get_render_cell_value.tsx
💚 Build SucceededMetrics [docs]Async chunks
Page load bundle
Unknown metric groupsESLint disabled line counts
Total ESLint disabled count
History
To update your PR or re-run it, just comment with: cc @dmitriynj |
kertal
reviewed
Jan 28, 2022
| @@ -237,7 +237,8 @@ export class DiscoverPlugin | |||
| defaultMessage: 'Table', | |||
| }), | |||
| order: 10, | |||
| Component: (props) => { | |||
| component: (props) => { | |||
| // eslint-disable-next-line react-hooks/rules-of-hooks | |||
There was a problem hiding this comment.
ah, I see, lint was complaining, got it :)
kertal
approved these changes
Jan 28, 2022
|
🥳 |
jloleysens
added a commit
to jloleysens/kibana
that referenced
this pull request
Jan 28, 2022
…fix-potential-race-condition-when-screenshotting * 'main' of github.com:elastic/kibana: (75 commits) [Reporting] Logging improvements while generating reports (elastic#123802) [Uptime] Default alert connectors email settings (elastic#123244) Update comparison series styles to match the main series (elastic#123858) [RAC][Uptime] remove extra dot from the uptime alert connector message (elastic#124000) [Exploratory view] Allow ability add extra actions in lens embeddable (elastic#123713) [SecuritySolution][Investigations] Add message about missing index in data view in analyzer (elastic#122859) [TSVB] Formatting in the left axis is not respected when I have two separate axis (elastic#123903) [Discover] Remove services from component dependencies (elastic#121691) Stop IM rule execution if there are no events (elastic#123811) [Security Solution][Endpoint] Update Fleet Trusted Apps and Host Isolation Exception cards to use exception list summary API (elastic#123900) [Security Solution][Exceptions] Switches modal to flyout component (elastic#123408) [Workplace Search] Fix bug where modal visible after deleting a group (elastic#123976) [Alerting] Remove state variables from action variable menu (elastic#123702) replace deprecated api usage (elastic#123970) Fix package policy merge logic for boolean values (elastic#123974) [Security Solution][Endpoint][Policy] Remove GET policy list api route (elastic#123873) Reenable alert_add test suite (elastic#123862) [Fleet] Remove usage of IFieldType in Fleet (elastic#123960) [Lists] Add an instance of `ExceptionListClient` with server extension points turned off to context object provided to callbacks (elastic#123885) [Maps] Add execution context (elastic#123651) ... # Conflicts: # x-pack/plugins/screenshotting/server/browsers/chromium/driver_factory/index.ts
awahab07
pushed a commit
to awahab07/kibana
that referenced
this pull request
Jan 31, 2022
* [Discover] remove services from component dependencies * [Discover] fix eslint * [Discover] fix imports * [Discover] fix build problems * [Discover] get rid of getServices and setServices * [Discover] fix unit tests, update services init process * [Discover] fix redundant dependency * [Discover] fix imports * [Discover] fix test implementation * Update src/plugins/discover/public/components/discover_grid/discover_grid.test.tsx Co-authored-by: Matthias Wilhelm <[email protected]> * [Discover] apply suggestions * [Discover] fix jest test Co-authored-by: Kibana Machine <[email protected]> Co-authored-by: Matthias Wilhelm <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR removes unnecessary services instance propagation through components tree and enables
useKibanahook.