Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade EUI to v37.1.1 #108210

Merged
merged 22 commits into from
Aug 16, 2021
Merged

Upgrade EUI to v37.1.1 #108210

merged 22 commits into from
Aug 16, 2021

Conversation

thompsongl
Copy link
Contributor

@thompsongl thompsongl commented Aug 11, 2021 •
edited
Loading

Summary

[email protected] ⏩ [email protected]

37.1.1

Bug fixes

  • Fixed EuiFormRow ignoring isDisabled prop on the child element. (#5022)

37.1.0

  • Added isDisabled prop to EuiFormRow that disables the child field element (#4908)

37.0.0

  • Added fleetApp and agentApp icons (#4989)
  • Added i18n tokens for EuiSuperDatePicker button title (#4998)

Bug fixes

  • Fixed incorrect date formatting on EuiSuperDatePicker button title (#4998)

Breaking changes

  • Removed EuiKeyboardAccessible (#4991)

@thompsongl thompsongl added v8.0.0 release_note:skip Skip the PR/issue when compiling release notes EUI v7.15.0 labels Aug 11, 2021
@thompsongl thompsongl marked this pull request as ready for review August 11, 2021 17:23
@thompsongl thompsongl requested review from a team as code owners August 11, 2021 17:23
@elasticmachine
Copy link
Contributor

Pinging @elastic/eui-design (EUI)

jbudz
jbudz approved these changes Aug 11, 2021
View reviewed changes
Copy link
Member

@jbudz jbudz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

src/dev/license_checker LGTM

@thompsongl thompsongl requested a review from a team as a code owner August 11, 2021 20:47
@thompsongl
Revert "disabled prop"
b77ff9a 
This reverts commit 68a48c4.
@thompsongl thompsongl changed the title Upgrade EUI to v37.1.0 Upgrade EUI to v37.2.0 Aug 12, 2021
@thompsongl thompsongl requested a review from a team as a code owner August 12, 2021 21:37
YulNaumenko
YulNaumenko approved these changes Aug 12, 2021
View reviewed changes
Copy link
Contributor

@YulNaumenko YulNaumenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alerting changes LGTM!

@thompsongl thompsongl changed the title Upgrade EUI to v37.2.0 Upgrade EUI to v37.1.1 Aug 13, 2021
@thompsongl
Copy link
Contributor Author

@elasticmachine merge upstream

crob611
crob611 approved these changes Aug 16, 2021
View reviewed changes
Copy link
Contributor

@crob611 crob611 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Presentation Team changes look good 👍

poffdeluxe
poffdeluxe approved these changes Aug 16, 2021
View reviewed changes
Copy link
Contributor

@poffdeluxe poffdeluxe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Presentation snapshot change LGTM

@thompsongl
Copy link
Contributor Author

@elasticmachine merge upstream

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
core 424.3KB 424.7KB +411.0B
kbnUiSharedDeps-elastic 2.6MB 2.6MB +302.0B
kbnUiSharedDeps-js 6.5MB 6.5MB +54.0B
total +767.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@thompsongl thompsongl merged commit f26591f into elastic:master Aug 16, 2021
@thompsongl thompsongl mentioned this pull request Aug 16, 2021
Merged
thompsongl added a commit to thompsongl/kibana that referenced this pull request Aug 16, 2021
@thompsongl @kibanamachine
Upgrade EUI to v37.1.1 (elastic#108210)
a1ad4cf 
* eui to 37.1.0

* i18n tokens

* license checker

* disabled prop

* i18n shapshot

* date title snapshots

* date title formatting

* date title formatting

* Revert "disabled prop"

This reverts commit 68a48c4.

* date title formatting

* eui to 37.2.0

* trial: outsideClickCloses

* Revert "trial: outsideClickCloses"

This reverts commit 4da2299.

* eui to 37.1.1

Co-authored-by: Kibana Machine <[email protected]>
thompsongl added a commit that referenced this pull request Aug 16, 2021
@thompsongl @kibanamachine
Upgrade EUI to v37.1.1 (#108210) (#108740)
dcdf872 
* eui to 37.1.0

* i18n tokens

* license checker

* disabled prop

* i18n shapshot

* date title snapshots

* date title formatting

* date title formatting

* Revert "disabled prop"

This reverts commit 68a48c4.

* date title formatting

* eui to 37.2.0

* trial: outsideClickCloses

* Revert "trial: outsideClickCloses"

This reverts commit 4da2299.

* eui to 37.1.1

Co-authored-by: Kibana Machine <[email protected]>

Co-authored-by: Kibana Machine <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@YulNaumenko YulNaumenko YulNaumenko approved these changes

@jbudz jbudz jbudz approved these changes

@lukeelmers lukeelmers lukeelmers approved these changes

@poffdeluxe poffdeluxe poffdeluxe approved these changes

@crob611 crob611 crob611 approved these changes

@academo academo academo approved these changes

@paul-tavares paul-tavares Awaiting requested review from paul-tavares

Assignees
No one assigned
Labels
EUI release_note:skip Skip the PR/issue when compiling release notes v7.15.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@thompsongl @elasticmachine @kibanamachine @academo @crob611 @poffdeluxe @lukeelmers @jbudz @YulNaumenko