Remove EuiKeyboardAccessible #4991
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
myasonik
force-pushed
the
mostly-remove-euikeyboardaccessible
branch
from
76eacf7 to
c3a5a36
Compare
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_4991/ |
cchaos
suggested changes
Jul 29, 2021
| @@ -39,6 +39,8 @@ interface Props { | |||
| children: ReactElement; | |||
| } | |||
|
|
|||
| // TODO remove - this implementation is not actually accessible | |||
| // https://github.com/elastic/eui/issues/4155 | |||
| export class EuiKeyboardAccessible extends Component<Props> { | |||
There was a problem hiding this comment.
Can we at least re-name to be table specific? So that when we "get rid of it", it might actually just be implementing a better solution to making the rows clickable.
There was a problem hiding this comment.
So... I ended up removing it afterall and reimplementing the same solution inline in EuiTableRow (but with only the bits it needs).
Assuming this merges, I'll update #4155 with the latest details.
Co-authored-by: Caroline Horn <[email protected]>
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_4991/ |
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_4991/ |
thompsongl
approved these changes
Jul 30, 2021
myasonik
changed the title
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_4991/ |
cchaos
approved these changes
Jul 30, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
EuiKeyboardAccessible has been deprecated since Oct 2020 and all instances have been removed from Kibana. Removed it from EUI though rewrote a small version of it to fill in the gap left in EuiBasicTable which uses it for clickable rows. (That's it's own a11y issue but a difficult and more involved fix so not going to tackle it all at once. #4155)
Checklist
Check against all themes for compatibility in both light and dark modesChecked in mobileChecked in Chrome, Safari, Edge, and FirefoxProps have proper autodocs and playground togglesChecked Code Sandbox works for the any docs examplesChecked for accessibility including keyboard-only and screenreader modes