Skip to content

Commit

Permalink
Remove EuiKeyboardAccessible (#4991)
Browse files Browse the repository at this point in the history
Co-authored-by: Caroline Horn <[email protected]>
  • Loading branch information
Michail Yasonik and cchaos authored Jul 30, 2021
1 parent f8f3ae7 commit 8e51c65
Show file tree
Hide file tree
Showing 11 changed files with 160 additions and 638 deletions.
4 changes: 4 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,10 @@

- Fixed incorrect date formatting on `EuiSuperDatePicker` button `title` ([#4998](https://github.com/elastic/eui/pull/4998))

**Breaking changes**

- Removed `EuiKeyboardAccessible` ([#4991](https://github.com/elastic/eui/pull/4991))

## [`36.1.0`](https://github.com/elastic/eui/tree/v36.1.0)

- Fixed color of `html` scrollbar in dark mode ([#4969](https://github.com/elastic/eui/pull/4969))
Expand Down
60 changes: 0 additions & 60 deletions src-docs/src/views/accessibility/accessibility_example.js
Original file line number Diff line number Diff line change
Expand Up @@ -5,26 +5,16 @@ import { renderToHtml } from '../../services';
import { GuideSectionTypes } from '../../components';

import {
EuiBadge,
EuiSpacer,
EuiCallOut,
EuiCode,
EuiLink,
EuiKeyboardAccessible,
EuiSkipLink,
EuiScreenReaderOnly,
} from '../../../../src/components';

import KeyboardAccessible from './keyboard_accessible';
import ScreenReaderOnly from './screen_reader';
import SkipLink from './skip_link';

const keyboardAccessibleSource = require('!!raw-loader!./keyboard_accessible');
const keyboardAccessibleHtml = renderToHtml(KeyboardAccessible);
const keyboardAccessibleSnippet = `<EuiKeyboardAccessible>
<!-- interactive child element -->
</EuiKeyboardAccessible>`;

const screenReaderOnlyHtml = renderToHtml(ScreenReaderOnly);
const screenReaderOnlySource = require('!!raw-loader!./screen_reader');
const screenReaderOnlySnippet = [
Expand Down Expand Up @@ -54,56 +44,6 @@ const skipLinkSnippet = [
export const AccessibilityExample = {
title: 'Accessibility',
sections: [
{
title: 'Keyboard accessible',
source: [
{
type: GuideSectionTypes.JS,
code: keyboardAccessibleSource,
},
{
type: GuideSectionTypes.HTML,
code: keyboardAccessibleHtml,
},
],
text: (
<>
<EuiBadge
color="danger"
href="https://github.com/elastic/eui/issues/1469"
target="_blank"
iconSide="right"
iconType="popout">
Set for deprecation. See details.
</EuiBadge>

<EuiSpacer />

<EuiCallOut
color="warning"
iconType="accessibility"
title="Deprecated because it often causes problems for screen reader users">
<p>
Though this component solved some problems for keyboard-only users
it also frequently introduced problems for screen reader users. As
such, we don&apos;t recommend it&apos;s continued use.
</p>
</EuiCallOut>

<EuiSpacer />

<p>
You can make interactive elements keyboard-accessible with the{' '}
<strong>EuiKeyboardAccessible</strong> component. This is necessary
for non-button elements and <EuiCode>a</EuiCode> tags without{' '}
<EuiCode>href</EuiCode> attributes.
</p>
</>
),
props: { EuiKeyboardAccessible },
snippet: keyboardAccessibleSnippet,
demo: <KeyboardAccessible />,
},
{
title: 'Screen reader only',
source: [
Expand Down
51 changes: 0 additions & 51 deletions src-docs/src/views/accessibility/keyboard_accessible.js

This file was deleted.

This file was deleted.

1 change: 0 additions & 1 deletion src/components/accessibility/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,5 @@
* Side Public License, v 1.
*/

export { EuiKeyboardAccessible } from './keyboard_accessible';
export { EuiScreenReaderOnly } from './screen_reader';
export { EuiSkipLink, EuiSkipLinkProps } from './skip_link';
Loading

0 comments on commit 8e51c65

Please sign in to comment.