Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[EuiBasicTable] row actions are inaccessible #4155

Open
myasonik opened this issue Oct 19, 2020 · 0 comments
Open

[EuiBasicTable] row actions are inaccessible #4155

myasonik opened this issue Oct 19, 2020 · 0 comments

Comments

@myasonik
Copy link
Contributor

Summary

When row actions are define, EuiBasicTable sets role=button onto each <tr> (which are natively of role=row and are within the fairly strict rules of table semantics). The solution largely works for keyboard users but can cause a muck for screen reader users.

Proposed solutions

The ideal solution for clickable rows looks something:

<tr onClick={rowActionButton.click()}>
  <td>{name}</td>
  <td>{phoneNumber}</td>
  <td>{rowActionButton}</td>
</tr>

With some CSS, you make the rows appear clickable for mouse users but screen reader and keyboard users get deferred to button within a cell. (Also makes the action more obvious to mouse users.)

Other solutions

Defining a structure like that might be a pretty big breaking change for EUI so I'm not sure about the practicalities of it. At the very least, it would be nice if EUI had an official way to create the accessible pattern.

Other options that could be explored are visually hidden buttons (but those can cause havoc for keyboard only users, so maybe something like a skiplink where it comes into view on focus?) or some custom gymnastics with a lot of aria-live (but this can be brittle and cause further confusion if not clear from the gate).

@github-actions github-actions bot added the Stale label Oct 4, 2024
@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Oct 11, 2024
@cee-chen cee-chen removed the Stale label Oct 14, 2024
@cee-chen cee-chen reopened this Oct 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants