Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[EuiIcon] Added fleetApp and agentApp icons #4989

Merged
merged 4 commits into from
Jul 29, 2021

Conversation

cchaos
Copy link
Contributor

@cchaos cchaos commented Jul 28, 2021

Closes #4981

Figma:

Screen Shot 2021-07-28 at 12 38 59 PM

Light vs Dark:

Screen Shot 2021-07-28 at 12 42 11 PM

Screen Shot 2021-07-28 at 12 41 46 PM

Screen Shot 2021-07-28 at 12 50 28 PM

Screen Shot 2021-07-28 at 12 50 21 PM

Non retina:

Screen Shot 2021-07-28 at 12 42 03 PM

Screen Shot 2021-07-28 at 12 50 38 PM

Checklist

  • Check against all themes for compatibility in both light and dark modes
  • [ ] Checked in mobile
  • Checked in Chrome, Safari, Edge, and Firefox
  • [ ] Props have proper autodocs and playground toggles
  • Added documentation
  • [ ] Checked Code Sandbox works for the any docs examples
  • Added or updated jest tests
  • [ ] Checked for breaking changes and labeled appropriately
  • [ ] Checked for accessibility including keyboard-only and screenreader modes
  • A changelog entry exists and is marked appropriately

@cchaos cchaos requested a review from elizabetdev July 28, 2021 17:02
appSearchApp: 'app_app_search',
apps: 'apps',
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other changes like this was from auto-sorting this list

@kibanamachine
Copy link

Preview documentation changes for this PR: https://eui.elastic.co/pr_4989/

Copy link
Contributor

@elizabetdev elizabetdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested in Chrome, Safari, Edge, and Firefox. LGTM! 🎉

@kibanamachine
Copy link

Preview documentation changes for this PR: https://eui.elastic.co/pr_4989/

@kibanamachine
Copy link

Preview documentation changes for this PR: https://eui.elastic.co/pr_4989/

@cchaos cchaos merged commit 25cd298 into elastic:master Jul 29, 2021
@cchaos cchaos deleted the new/fleet_agent_icons branch July 29, 2021 00:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Elastic Agent and Fleet icons
3 participants