[EuiSuperDatePicker] Button title formatting and i18n
#4998
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_4998/ |
myasonik
approved these changes
Jul 30, 2021
cchaos
reviewed
Jul 30, 2021
| @@ -74,11 +75,24 @@ export const EuiDatePopoverButton: FunctionComponent<EuiDatePopoverButtonProps> | |||
| }, | |||
| ]); | |||
|
|
|||
| let title = value; | |||
| const formattedValue = formatTimeString(value, dateFormat, roundUp, locale); | |||
| let title = formattedValue; | |||
There was a problem hiding this comment.
Suggested change
| let title = formattedValue; | |
| // Tooltip value may be different from button label because of validity/update status | |
| let title = formattedValue; |
There was a problem hiding this comment.
I was just having a hard time grokking why title was just set to the same as formattedValue.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #4995 by formatting the date value passed to
titleand adds i18n tokens.Checklist
- [ ] Check against all themes for compatibility in both light and dark modes- [ ] Checked in mobile- [ ] Checked in Chrome, Safari, Edge, and Firefox- [ ] Props have proper autodocs and playground toggles- [ ] Added documentation- [ ] Checked Code Sandbox works for the any docs examples- [ ] Added or updated jest tests- [ ] Checked for breaking changes and labeled appropriately- [ ] Checked for accessibility including keyboard-only and screenreader modes