Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Failing test: X-Pack Saved Object Tagging Functional Tests.x-pack/test/saved_object_tagging/functional/tests/visualize_integration·ts - saved objects tagging - functional tests visualize integration creating allows to create a tag from the tag selector #89958

Closed
kibanamachine opened this issue Feb 2, 2021 · 17 comments · Fixed by #142917
Closed

Failing test: X-Pack Saved Object Tagging Functional Tests.x-pack/test/saved_object_tagging/functional/tests/visualize_integration·ts - saved objects tagging - functional tests visualize integration creating allows to create a tag from the tag selector #89958

kibanamachine opened this issue Feb 2, 2021 · 17 comments · Fixed by #142917
Assignees
@gsoldevila
Labels
failed-test A test failure on a tracked branch, potentially flaky-test impact:critical This issue should be addressed immediately due to a critical level of impact on the product. loe:small Small Level of Effort Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc

Comments

@kibanamachine
Copy link
Contributor

kibanamachine commented Feb 2, 2021 •
edited
Loading

A test failed on a tracked branch

Error: retry.try timeout: Error: save modal still open
    at /dev/shm/workspace/parallel/23/kibana/test/functional/page_objects/common_page.ts:435:17
    at runMicrotasks (<anonymous>)
    at processTicksAndRejections (internal/process/task_queues.js:93:5)
    at runAttempt (/dev/shm/workspace/parallel/23/kibana/test/common/services/retry/retry_for_success.ts:27:15)
    at retryForSuccess (/dev/shm/workspace/parallel/23/kibana/test/common/services/retry/retry_for_success.ts:66:21)
    at Retry.try (/dev/shm/workspace/parallel/23/kibana/test/common/services/retry/retry.ts:32:14)
    at CommonPage.waitForSaveModalToClose (/dev/shm/workspace/parallel/23/kibana/test/functional/page_objects/common_page.ts:433:7)
    at Context.<anonymous> (test/saved_object_tagging/functional/tests/visualize_integration.ts:143:9)
    at Object.apply (/dev/shm/workspace/parallel/23/kibana/packages/kbn-test/src/functional_test_runner/lib/mocha/wrap_function.js:73:16)
    at onFailure (/dev/shm/workspace/parallel/23/kibana/test/common/services/retry/retry_for_success.ts:17:9)
    at retryForSuccess (/dev/shm/workspace/parallel/23/kibana/test/common/services/retry/retry_for_success.ts:57:13)
    at Retry.try (/dev/shm/workspace/parallel/23/kibana/test/common/services/retry/retry.ts:32:14)
    at CommonPage.waitForSaveModalToClose (/dev/shm/workspace/parallel/23/kibana/test/functional/page_objects/common_page.ts:433:7)
    at Context.<anonymous> (test/saved_object_tagging/functional/tests/visualize_integration.ts:143:9)
    at Object.apply (/dev/shm/workspace/parallel/23/kibana/packages/kbn-test/src/functional_test_runner/lib/mocha/wrap_function.js:73:16)

First failure: Jenkins Build
@kibanamachine kibanamachine added the failed-test A test failure on a tracked branch, potentially flaky-test label Feb 2, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app-services (Team:AppServices)

@spalger
Copy link
Contributor

spalger commented Feb 2, 2021

No other failures recorded in the last 30 days, but #88639 was recently skipped in this suite

@kibanamachine
Copy link
Contributor Author

New failure: Jenkins Build

@kibanamachine
Copy link
Contributor Author

New failure: Jenkins Build

tylersmalley added a commit that referenced this issue Feb 17, 2021
@tylersmalley
skip flaky suite (#89958)
7a2f74f
tylersmalley added a commit that referenced this issue Feb 17, 2021
@tylersmalley
skip flaky suite (#89958)
b51d3f0
@tylersmalley
Copy link
Contributor

tylersmalley commented Feb 17, 2021 •
edited
Loading

Skipped

image

master: 7a2f74f
7.x: b51d3f0

@exalate-issue-sync exalate-issue-sync bot added impact:critical This issue should be addressed immediately due to a critical level of impact on the product. loe:small Small Level of Effort labels Jun 21, 2021
@petrklapka petrklapka added Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc and removed Team:AppServicesSv labels Nov 8, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-core (Team:Core)

@TinaHeiligers TinaHeiligers mentioned this issue Oct 6, 2022
Merged
@kibanamachine kibanamachine reopened this Jan 23, 2023
@kibanamachine
Copy link
Contributor Author

New failure: CI Build - main

@afharo
Copy link
Member

afharo commented Aug 31, 2023

Fixed by #164273

@afharo afharo closed this as completed Aug 31, 2023
@kibanamachine kibanamachine reopened this Sep 1, 2023
@kibanamachine
Copy link
Contributor Author

New failure: CI Build - main

@kibanamachine
Copy link
Contributor Author

New failure: CI Build - main

@kibanamachine
Copy link
Contributor Author

New failure: CI Build - main

@kibanamachine
Copy link
Contributor Author

New failure: CI Build - main

mistic added a commit that referenced this issue Oct 9, 2023
@mistic
skip flaky suite (#89958)
dd06ae4
@mistic
Copy link
Member

mistic commented Oct 9, 2023 •
edited
Loading

Skipped.

main: dd06ae4
8.11: 213c5aa

dej611 pushed a commit to dej611/kibana that referenced this issue Oct 17, 2023
@mistic @dej611
skip flaky suite (elastic#89958)
11fef24
@kibanamachine
Copy link
Contributor Author

New failure: CI Build - 8.11

@mistic mistic added the v8.11.1 label Oct 18, 2023
@gsoldevila gsoldevila self-assigned this Oct 25, 2023
@gsoldevila
Copy link
Contributor

gsoldevila commented Oct 25, 2023 •
edited
Loading

Looking at the details of the error on CI artifacts, it seems that the UI remains stuck on the type selection screen:

image

My theory is that the click on the Text (aka markdown) is lost (perhaps actioned before a handler is attached to the Button).

@gsoldevila gsoldevila mentioned this issue Oct 25, 2023
Merged
gsoldevila added a commit that referenced this issue Oct 26, 2023
@gsoldevila
Add a slight delay before selecting a visualization type (#169851)
3d19006 
## Summary

Attempt at fixing #89958

As per my [latest
comment](#89958 (comment))
on the issue, I believe that the test logic sometimes fails to select
the appropriate visualisation type, in this case `Text` (aka markdown).

The failure manifests [a couple of steps
later](https://github.com/elastic/kibana/blob/main/x-pack/test/saved_object_tagging/functional/tests/visualize_integration.ts#L155),
as this operation does not meet the expected "before state".

The strategy of this fix consists in introducing an extra step,
searching for the visualisation type, which should give the UI enough
time to attach an event handler to the control.
kibanamachine pushed a commit to kibanamachine/kibana that referenced this issue Oct 26, 2023
@gsoldevila
Add a slight delay before selecting a visualization type (elastic#169851
2e2b4ff 
)

## Summary

Attempt at fixing elastic#89958

As per my [latest
comment](elastic#89958 (comment))
on the issue, I believe that the test logic sometimes fails to select
the appropriate visualisation type, in this case `Text` (aka markdown).

The failure manifests [a couple of steps
later](https://github.com/elastic/kibana/blob/main/x-pack/test/saved_object_tagging/functional/tests/visualize_integration.ts#L155),
as this operation does not meet the expected "before state".

The strategy of this fix consists in introducing an extra step,
searching for the visualisation type, which should give the UI enough
time to attach an event handler to the control.

(cherry picked from commit 3d19006)
kibanamachine referenced this issue Oct 26, 2023
@kibanamachine @gsoldevila
[8.11] Add a slight delay before selecting a visualization type (#169851
bfa39c7 
) (#169917)

# Backport

This will backport the following commits from `main` to `8.11`:
- [Add a slight delay before selecting a visualization type
(#169851)](#169851)

<!--- Backport version: 8.9.7 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Gerard
Soldevila","email":"[email protected]"},"sourceCommit":{"committedDate":"2023-10-26T09:50:04Z","message":"Add
a slight delay before selecting a visualization type (#169851)\n\n##
Summary\r\n\r\nAttempt at fixing
https://github.com/elastic/kibana/issues/89958\r\n\r\nAs per my
[latest\r\ncomment](https://github.com/elastic/kibana/issues/89958#issuecomment-1779553320)\r\non
the issue, I believe that the test logic sometimes fails to
select\r\nthe appropriate visualisation type, in this case `Text` (aka
markdown).\r\n\r\nThe failure manifests [a couple of
steps\r\nlater](https://github.com/elastic/kibana/blob/main/x-pack/test/saved_object_tagging/functional/tests/visualize_integration.ts#L155),\r\nas
this operation does not meet the expected \"before state\".\r\n\r\nThe
strategy of this fix consists in introducing an extra step,\r\nsearching
for the visualisation type, which should give the UI enough\r\ntime to
attach an event handler to the
control.","sha":"3d19006052a33b224b03c7fbda2ed408d9a43462","branchLabelMapping":{"^v8.12.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Team:Core","release_note:skip","test-failure-flaky","Team:SharedUX","backport:prev-minor","v8.12.0"],"number":169851,"url":"https://github.com/elastic/kibana/pull/169851","mergeCommit":{"message":"Add
a slight delay before selecting a visualization type (#169851)\n\n##
Summary\r\n\r\nAttempt at fixing
https://github.com/elastic/kibana/issues/89958\r\n\r\nAs per my
[latest\r\ncomment](https://github.com/elastic/kibana/issues/89958#issuecomment-1779553320)\r\non
the issue, I believe that the test logic sometimes fails to
select\r\nthe appropriate visualisation type, in this case `Text` (aka
markdown).\r\n\r\nThe failure manifests [a couple of
steps\r\nlater](https://github.com/elastic/kibana/blob/main/x-pack/test/saved_object_tagging/functional/tests/visualize_integration.ts#L155),\r\nas
this operation does not meet the expected \"before state\".\r\n\r\nThe
strategy of this fix consists in introducing an extra step,\r\nsearching
for the visualisation type, which should give the UI enough\r\ntime to
attach an event handler to the
control.","sha":"3d19006052a33b224b03c7fbda2ed408d9a43462"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v8.12.0","labelRegex":"^v8.12.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/169851","number":169851,"mergeCommit":{"message":"Add
a slight delay before selecting a visualization type (#169851)\n\n##
Summary\r\n\r\nAttempt at fixing
https://github.com/elastic/kibana/issues/89958\r\n\r\nAs per my
[latest\r\ncomment](https://github.com/elastic/kibana/issues/89958#issuecomment-1779553320)\r\non
the issue, I believe that the test logic sometimes fails to
select\r\nthe appropriate visualisation type, in this case `Text` (aka
markdown).\r\n\r\nThe failure manifests [a couple of
steps\r\nlater](https://github.com/elastic/kibana/blob/main/x-pack/test/saved_object_tagging/functional/tests/visualize_integration.ts#L155),\r\nas
this operation does not meet the expected \"before state\".\r\n\r\nThe
strategy of this fix consists in introducing an extra step,\r\nsearching
for the visualisation type, which should give the UI enough\r\ntime to
attach an event handler to the
control.","sha":"3d19006052a33b224b03c7fbda2ed408d9a43462"}}]}]
BACKPORT-->

Co-authored-by: Gerard Soldevila <[email protected]>
@gsoldevila
Copy link
Contributor

UPDATE: this GH issue contains CI build failures that are of a different nature (e.g. this one), which are not tackled by the PR above.

Thus, I am keeping the issue open, in case these other failures appear again.

@gsoldevila gsoldevila mentioned this issue Oct 30, 2023
Merged
gsoldevila added a commit that referenced this issue Oct 30, 2023
@gsoldevila
Address saved_object_tagging flakiness (#170114)
036918d 
## Summary

Fixes:
* #89958
* #150249
* #167812
* #167560

Uses same strategy as Stratoula's
[PR](#167599). It also adds a
"click" step to make sure the form control has the focus (as we do with
the other form controls on the same `fillForm` method).

The tests above fail cause the logic fails to clean the default tag
colour before entering a new one, resulting in:

![image](https://github.com/elastic/kibana/assets/25349407/e753aa64-4132-4094-af01-c17d91223172)

Also fixes:
* #163817

[This
one](https://buildkite.com/elastic/kibana-on-merge/builds/36347#018b0068-ec42-47de-804d-b63a42b5b3e2)
is looks like a lost click on the Delete modal confirm button (modal
still present after 30s):


![image](https://github.com/elastic/kibana/assets/25349407/b2025b45-5030-4b6a-95f9-58d77fd3d2ea)
kibanamachine pushed a commit to kibanamachine/kibana that referenced this issue Oct 30, 2023
@gsoldevila
Address saved_object_tagging flakiness (elastic#170114)
e3d5e65 
## Summary

Fixes:
* elastic#89958
* elastic#150249
* elastic#167812
* elastic#167560

Uses same strategy as Stratoula's
[PR](elastic#167599). It also adds a
"click" step to make sure the form control has the focus (as we do with
the other form controls on the same `fillForm` method).

The tests above fail cause the logic fails to clean the default tag
colour before entering a new one, resulting in:

![image](https://github.com/elastic/kibana/assets/25349407/e753aa64-4132-4094-af01-c17d91223172)

Also fixes:
* elastic#163817

[This
one](https://buildkite.com/elastic/kibana-on-merge/builds/36347#018b0068-ec42-47de-804d-b63a42b5b3e2)
is looks like a lost click on the Delete modal confirm button (modal
still present after 30s):

![image](https://github.com/elastic/kibana/assets/25349407/b2025b45-5030-4b6a-95f9-58d77fd3d2ea)

(cherry picked from commit 036918d)
kibanamachine referenced this issue Oct 30, 2023
@kibanamachine @gsoldevila
[8.11] Address saved_object_tagging flakiness (#170114) (#170190)
c0bd227 
# Backport

This will backport the following commits from `main` to `8.11`:
- [Address saved_object_tagging flakiness
(#170114)](#170114)

<!--- Backport version: 8.9.7 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Gerard
Soldevila","email":"[email protected]"},"sourceCommit":{"committedDate":"2023-10-30T21:21:27Z","message":"Address
saved_object_tagging flakiness (#170114)\n\n##
Summary\r\n\r\nFixes:\r\n*
https://github.com/elastic/kibana/issues/89958\r\n*
https://github.com/elastic/kibana/issues/150249\r\n*
https://github.com/elastic/kibana/issues/167812\r\n*
https://github.com/elastic/kibana/issues/167560\r\n\r\nUses same
strategy as
Stratoula's\r\n[PR](#167599). It
also adds a\r\n\"click\" step to make sure the form control has the
focus (as we do with\r\nthe other form controls on the same `fillForm`
method).\r\n\r\nThe tests above fail cause the logic fails to clean the
default tag\r\ncolour before entering a new one, resulting
in:\r\n\r\n![image](https://github.com/elastic/kibana/assets/25349407/e753aa64-4132-4094-af01-c17d91223172)\r\n\r\nAlso
fixes:\r\n*
https://github.com/elastic/kibana/issues/163817\r\n\r\n[This\r\none](https://buildkite.com/elastic/kibana-on-merge/builds/36347#018b0068-ec42-47de-804d-b63a42b5b3e2)\r\nis
looks like a lost click on the Delete modal confirm button
(modal\r\nstill present after
30s):\r\n\r\n\r\n![image](https://github.com/elastic/kibana/assets/25349407/b2025b45-5030-4b6a-95f9-58d77fd3d2ea)","sha":"036918d017c9d1ee20467f5ced9934f944d9ff00","branchLabelMapping":{"^v8.12.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Team:Core","release_note:skip","test-failure-flaky","Team:SharedUX","backport:prev-minor","v8.12.0"],"number":170114,"url":"https://github.com/elastic/kibana/pull/170114","mergeCommit":{"message":"Address
saved_object_tagging flakiness (#170114)\n\n##
Summary\r\n\r\nFixes:\r\n*
https://github.com/elastic/kibana/issues/89958\r\n*
https://github.com/elastic/kibana/issues/150249\r\n*
https://github.com/elastic/kibana/issues/167812\r\n*
https://github.com/elastic/kibana/issues/167560\r\n\r\nUses same
strategy as
Stratoula's\r\n[PR](#167599). It
also adds a\r\n\"click\" step to make sure the form control has the
focus (as we do with\r\nthe other form controls on the same `fillForm`
method).\r\n\r\nThe tests above fail cause the logic fails to clean the
default tag\r\ncolour before entering a new one, resulting
in:\r\n\r\n![image](https://github.com/elastic/kibana/assets/25349407/e753aa64-4132-4094-af01-c17d91223172)\r\n\r\nAlso
fixes:\r\n*
https://github.com/elastic/kibana/issues/163817\r\n\r\n[This\r\none](https://buildkite.com/elastic/kibana-on-merge/builds/36347#018b0068-ec42-47de-804d-b63a42b5b3e2)\r\nis
looks like a lost click on the Delete modal confirm button
(modal\r\nstill present after
30s):\r\n\r\n\r\n![image](https://github.com/elastic/kibana/assets/25349407/b2025b45-5030-4b6a-95f9-58d77fd3d2ea)","sha":"036918d017c9d1ee20467f5ced9934f944d9ff00"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v8.12.0","labelRegex":"^v8.12.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/170114","number":170114,"mergeCommit":{"message":"Address
saved_object_tagging flakiness (#170114)\n\n##
Summary\r\n\r\nFixes:\r\n*
https://github.com/elastic/kibana/issues/89958\r\n*
https://github.com/elastic/kibana/issues/150249\r\n*
https://github.com/elastic/kibana/issues/167812\r\n*
https://github.com/elastic/kibana/issues/167560\r\n\r\nUses same
strategy as
Stratoula's\r\n[PR](#167599). It
also adds a\r\n\"click\" step to make sure the form control has the
focus (as we do with\r\nthe other form controls on the same `fillForm`
method).\r\n\r\nThe tests above fail cause the logic fails to clean the
default tag\r\ncolour before entering a new one, resulting
in:\r\n\r\n![image](https://github.com/elastic/kibana/assets/25349407/e753aa64-4132-4094-af01-c17d91223172)\r\n\r\nAlso
fixes:\r\n*
https://github.com/elastic/kibana/issues/163817\r\n\r\n[This\r\none](https://buildkite.com/elastic/kibana-on-merge/builds/36347#018b0068-ec42-47de-804d-b63a42b5b3e2)\r\nis
looks like a lost click on the Delete modal confirm button
(modal\r\nstill present after
30s):\r\n\r\n\r\n![image](https://github.com/elastic/kibana/assets/25349407/b2025b45-5030-4b6a-95f9-58d77fd3d2ea)","sha":"036918d017c9d1ee20467f5ced9934f944d9ff00"}}]}]
BACKPORT-->

Co-authored-by: Gerard Soldevila <[email protected]>
@gsoldevila
Copy link
Contributor

Hopefully fixed by #170114

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gsoldevila gsoldevila

Labels
failed-test A test failure on a tracked branch, potentially flaky-test impact:critical This issue should be addressed immediately due to a critical level of impact on the product. loe:small Small Level of Effort Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Unskips visualize integration tests TinaHeiligers/kibana
8 participants
@tylersmalley @spalger @mistic @afharo @elasticmachine @gsoldevila @kibanamachine @petrklapka