Address saved_object_tagging flakiness #170114
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gsoldevila
added
Team:Core
|
Flaky test runner pipeline |
|
Pinging @elastic/kibana-core (Team:Core) |
|
Pinging @elastic/appex-sharedux (Team:SharedUX) |
pgayvallet
approved these changes
Oct 30, 2023
gsoldevila
changed the title
💛 Build succeeded, but was flaky
Failed CI StepsTest Failures
Metrics [docs]
History
To update your PR or re-run it, just comment with: |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Oct 30, 2023
## Summary Fixes: * elastic#89958 * elastic#150249 * elastic#167812 * elastic#167560 Uses same strategy as Stratoula's [PR](elastic#167599). It also adds a "click" step to make sure the form control has the focus (as we do with the other form controls on the same `fillForm` method). The tests above fail cause the logic fails to clean the default tag colour before entering a new one, resulting in:  Also fixes: * elastic#163817 [This one](https://buildkite.com/elastic/kibana-on-merge/builds/36347#018b0068-ec42-47de-804d-b63a42b5b3e2) is looks like a lost click on the Delete modal confirm button (modal still present after 30s):  (cherry picked from commit 036918d)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Oct 30, 2023
# Backport This will backport the following commits from `main` to `8.11`: - [Address saved_object_tagging flakiness (#170114)](#170114) <!--- Backport version: 8.9.7 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Gerard Soldevila","email":"[email protected]"},"sourceCommit":{"committedDate":"2023-10-30T21:21:27Z","message":"Address saved_object_tagging flakiness (#170114)\n\n## Summary\r\n\r\nFixes:\r\n* https://github.com/elastic/kibana/issues/89958\r\n* https://github.com/elastic/kibana/issues/150249\r\n* https://github.com/elastic/kibana/issues/167812\r\n* https://github.com/elastic/kibana/issues/167560\r\n\r\nUses same strategy as Stratoula's\r\n[PR](#167599). It also adds a\r\n\"click\" step to make sure the form control has the focus (as we do with\r\nthe other form controls on the same `fillForm` method).\r\n\r\nThe tests above fail cause the logic fails to clean the default tag\r\ncolour before entering a new one, resulting in:\r\n\r\n\r\n\r\nAlso fixes:\r\n* https://github.com/elastic/kibana/issues/163817\r\n\r\n[This\r\none](https://buildkite.com/elastic/kibana-on-merge/builds/36347#018b0068-ec42-47de-804d-b63a42b5b3e2)\r\nis looks like a lost click on the Delete modal confirm button (modal\r\nstill present after 30s):\r\n\r\n\r\n","sha":"036918d017c9d1ee20467f5ced9934f944d9ff00","branchLabelMapping":{"^v8.12.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Team:Core","release_note:skip","test-failure-flaky","Team:SharedUX","backport:prev-minor","v8.12.0"],"number":170114,"url":"https://github.com/elastic/kibana/pull/170114","mergeCommit":{"message":"Address saved_object_tagging flakiness (#170114)\n\n## Summary\r\n\r\nFixes:\r\n* https://github.com/elastic/kibana/issues/89958\r\n* https://github.com/elastic/kibana/issues/150249\r\n* https://github.com/elastic/kibana/issues/167812\r\n* https://github.com/elastic/kibana/issues/167560\r\n\r\nUses same strategy as Stratoula's\r\n[PR](#167599). It also adds a\r\n\"click\" step to make sure the form control has the focus (as we do with\r\nthe other form controls on the same `fillForm` method).\r\n\r\nThe tests above fail cause the logic fails to clean the default tag\r\ncolour before entering a new one, resulting in:\r\n\r\n\r\n\r\nAlso fixes:\r\n* https://github.com/elastic/kibana/issues/163817\r\n\r\n[This\r\none](https://buildkite.com/elastic/kibana-on-merge/builds/36347#018b0068-ec42-47de-804d-b63a42b5b3e2)\r\nis looks like a lost click on the Delete modal confirm button (modal\r\nstill present after 30s):\r\n\r\n\r\n","sha":"036918d017c9d1ee20467f5ced9934f944d9ff00"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v8.12.0","labelRegex":"^v8.12.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/170114","number":170114,"mergeCommit":{"message":"Address saved_object_tagging flakiness (#170114)\n\n## Summary\r\n\r\nFixes:\r\n* https://github.com/elastic/kibana/issues/89958\r\n* https://github.com/elastic/kibana/issues/150249\r\n* https://github.com/elastic/kibana/issues/167812\r\n* https://github.com/elastic/kibana/issues/167560\r\n\r\nUses same strategy as Stratoula's\r\n[PR](#167599). It also adds a\r\n\"click\" step to make sure the form control has the focus (as we do with\r\nthe other form controls on the same `fillForm` method).\r\n\r\nThe tests above fail cause the logic fails to clean the default tag\r\ncolour before entering a new one, resulting in:\r\n\r\n\r\n\r\nAlso fixes:\r\n* https://github.com/elastic/kibana/issues/163817\r\n\r\n[This\r\none](https://buildkite.com/elastic/kibana-on-merge/builds/36347#018b0068-ec42-47de-804d-b63a42b5b3e2)\r\nis looks like a lost click on the Delete modal confirm button (modal\r\nstill present after 30s):\r\n\r\n\r\n","sha":"036918d017c9d1ee20467f5ced9934f944d9ff00"}}]}] BACKPORT--> Co-authored-by: Gerard Soldevila <[email protected]>
This was referenced Oct 31, 2023
This was referenced Oct 31, 2023
This was referenced Oct 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes:
Uses same strategy as Stratoula's PR. It also adds a "click" step to make sure the form control has the focus (as we do with the other form controls on the same
fillFormmethod).The tests above fail cause the logic fails to clean the default tag colour before entering a new one, resulting in:
Also fixes:
This one is looks like a lost click on the Delete modal confirm button (modal still present after 30s):