-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Failing test: X-Pack Saved Object Tagging Functional Tests.x-pack/test/saved_object_tagging/functional/tests/bulk_actions·ts - saved objects tagging - functional tests table bulk actions bulk delete deletes multiple tags #163817
Labels
failed-test
A test failure on a tracked branch, potentially flaky-test
Team:SharedUX
Team label for AppEx-SharedUX (formerly Global Experience)
Comments
kibanamachine
added
the
failed-test
A test failure on a tracked branch, potentially flaky-test
label
Aug 14, 2023
kibanamachine
added
the
Team:SharedUX
Team label for AppEx-SharedUX (formerly Global Experience)
label
Aug 14, 2023
Pinging @elastic/appex-sharedux (Team:SharedUX) |
New failure: CI Build - main |
Skipped. main: c57afb0 |
dej611
pushed a commit
to dej611/kibana
that referenced
this issue
Oct 17, 2023
gsoldevila
added a commit
that referenced
this issue
Oct 30, 2023
## Summary Fixes: * #89958 * #150249 * #167812 * #167560 Uses same strategy as Stratoula's [PR](#167599). It also adds a "click" step to make sure the form control has the focus (as we do with the other form controls on the same `fillForm` method). The tests above fail cause the logic fails to clean the default tag colour before entering a new one, resulting in: ![image](https://github.com/elastic/kibana/assets/25349407/e753aa64-4132-4094-af01-c17d91223172) Also fixes: * #163817 [This one](https://buildkite.com/elastic/kibana-on-merge/builds/36347#018b0068-ec42-47de-804d-b63a42b5b3e2) is looks like a lost click on the Delete modal confirm button (modal still present after 30s): ![image](https://github.com/elastic/kibana/assets/25349407/b2025b45-5030-4b6a-95f9-58d77fd3d2ea)
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this issue
Oct 30, 2023
## Summary Fixes: * elastic#89958 * elastic#150249 * elastic#167812 * elastic#167560 Uses same strategy as Stratoula's [PR](elastic#167599). It also adds a "click" step to make sure the form control has the focus (as we do with the other form controls on the same `fillForm` method). The tests above fail cause the logic fails to clean the default tag colour before entering a new one, resulting in: ![image](https://github.com/elastic/kibana/assets/25349407/e753aa64-4132-4094-af01-c17d91223172) Also fixes: * elastic#163817 [This one](https://buildkite.com/elastic/kibana-on-merge/builds/36347#018b0068-ec42-47de-804d-b63a42b5b3e2) is looks like a lost click on the Delete modal confirm button (modal still present after 30s): ![image](https://github.com/elastic/kibana/assets/25349407/b2025b45-5030-4b6a-95f9-58d77fd3d2ea) (cherry picked from commit 036918d)
kibanamachine
referenced
this issue
Oct 30, 2023
# Backport This will backport the following commits from `main` to `8.11`: - [Address saved_object_tagging flakiness (#170114)](#170114) <!--- Backport version: 8.9.7 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Gerard Soldevila","email":"[email protected]"},"sourceCommit":{"committedDate":"2023-10-30T21:21:27Z","message":"Address saved_object_tagging flakiness (#170114)\n\n## Summary\r\n\r\nFixes:\r\n* https://github.com/elastic/kibana/issues/89958\r\n* https://github.com/elastic/kibana/issues/150249\r\n* https://github.com/elastic/kibana/issues/167812\r\n* https://github.com/elastic/kibana/issues/167560\r\n\r\nUses same strategy as Stratoula's\r\n[PR](#167599). It also adds a\r\n\"click\" step to make sure the form control has the focus (as we do with\r\nthe other form controls on the same `fillForm` method).\r\n\r\nThe tests above fail cause the logic fails to clean the default tag\r\ncolour before entering a new one, resulting in:\r\n\r\n![image](https://github.com/elastic/kibana/assets/25349407/e753aa64-4132-4094-af01-c17d91223172)\r\n\r\nAlso fixes:\r\n* https://github.com/elastic/kibana/issues/163817\r\n\r\n[This\r\none](https://buildkite.com/elastic/kibana-on-merge/builds/36347#018b0068-ec42-47de-804d-b63a42b5b3e2)\r\nis looks like a lost click on the Delete modal confirm button (modal\r\nstill present after 30s):\r\n\r\n\r\n![image](https://github.com/elastic/kibana/assets/25349407/b2025b45-5030-4b6a-95f9-58d77fd3d2ea)","sha":"036918d017c9d1ee20467f5ced9934f944d9ff00","branchLabelMapping":{"^v8.12.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Team:Core","release_note:skip","test-failure-flaky","Team:SharedUX","backport:prev-minor","v8.12.0"],"number":170114,"url":"https://github.com/elastic/kibana/pull/170114","mergeCommit":{"message":"Address saved_object_tagging flakiness (#170114)\n\n## Summary\r\n\r\nFixes:\r\n* https://github.com/elastic/kibana/issues/89958\r\n* https://github.com/elastic/kibana/issues/150249\r\n* https://github.com/elastic/kibana/issues/167812\r\n* https://github.com/elastic/kibana/issues/167560\r\n\r\nUses same strategy as Stratoula's\r\n[PR](#167599). It also adds a\r\n\"click\" step to make sure the form control has the focus (as we do with\r\nthe other form controls on the same `fillForm` method).\r\n\r\nThe tests above fail cause the logic fails to clean the default tag\r\ncolour before entering a new one, resulting in:\r\n\r\n![image](https://github.com/elastic/kibana/assets/25349407/e753aa64-4132-4094-af01-c17d91223172)\r\n\r\nAlso fixes:\r\n* https://github.com/elastic/kibana/issues/163817\r\n\r\n[This\r\none](https://buildkite.com/elastic/kibana-on-merge/builds/36347#018b0068-ec42-47de-804d-b63a42b5b3e2)\r\nis looks like a lost click on the Delete modal confirm button (modal\r\nstill present after 30s):\r\n\r\n\r\n![image](https://github.com/elastic/kibana/assets/25349407/b2025b45-5030-4b6a-95f9-58d77fd3d2ea)","sha":"036918d017c9d1ee20467f5ced9934f944d9ff00"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v8.12.0","labelRegex":"^v8.12.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/170114","number":170114,"mergeCommit":{"message":"Address saved_object_tagging flakiness (#170114)\n\n## Summary\r\n\r\nFixes:\r\n* https://github.com/elastic/kibana/issues/89958\r\n* https://github.com/elastic/kibana/issues/150249\r\n* https://github.com/elastic/kibana/issues/167812\r\n* https://github.com/elastic/kibana/issues/167560\r\n\r\nUses same strategy as Stratoula's\r\n[PR](#167599). It also adds a\r\n\"click\" step to make sure the form control has the focus (as we do with\r\nthe other form controls on the same `fillForm` method).\r\n\r\nThe tests above fail cause the logic fails to clean the default tag\r\ncolour before entering a new one, resulting in:\r\n\r\n![image](https://github.com/elastic/kibana/assets/25349407/e753aa64-4132-4094-af01-c17d91223172)\r\n\r\nAlso fixes:\r\n* https://github.com/elastic/kibana/issues/163817\r\n\r\n[This\r\none](https://buildkite.com/elastic/kibana-on-merge/builds/36347#018b0068-ec42-47de-804d-b63a42b5b3e2)\r\nis looks like a lost click on the Delete modal confirm button (modal\r\nstill present after 30s):\r\n\r\n\r\n![image](https://github.com/elastic/kibana/assets/25349407/b2025b45-5030-4b6a-95f9-58d77fd3d2ea)","sha":"036918d017c9d1ee20467f5ced9934f944d9ff00"}}]}] BACKPORT--> Co-authored-by: Gerard Soldevila <[email protected]>
Hopefully fixed by #170114 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
failed-test
A test failure on a tracked branch, potentially flaky-test
Team:SharedUX
Team label for AppEx-SharedUX (formerly Global Experience)
A test failed on a tracked branch
First failure: CI Build - main
The text was updated successfully, but these errors were encountered: