-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SavedObject tagging] Fix functional test for bulk delete tags #164321
[SavedObject tagging] Fix functional test for bulk delete tags #164321
Conversation
Pinging @elastic/appex-sharedux (Team:SharedUX) |
@sebelga, have you run it in the flaky test runner? all good? |
@Dosant : Running in isolation works fine. The problem is when ran with the other tests that can create flakiness
Job created: https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/2945 |
Also... this test was not skipped. So it is running on all the other PRs 😊 |
💚 Build Succeeded
Metrics [docs]
History
To update your PR or re-run it, just comment with: cc @sebelga |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for running the flaky runner. seems stable
Thanks for the review @Dosant 👍 |
In this PR I've fixed a failing functional test when bulk deleting multiple tags.
When running in isolation the test was passing locally. I decided to make it slightly more robust in case other tests create tags and don't clean the resource after the test is ran.
Fixes #163817