Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SavedObject tagging] Fix functional test for bulk delete tags #164321

Merged
merged 7 commits into from
Aug 22, 2023

Conversation

sebelga
Copy link
Contributor

@sebelga sebelga commented Aug 21, 2023

In this PR I've fixed a failing functional test when bulk deleting multiple tags.

When running in isolation the test was passing locally. I decided to make it slightly more robust in case other tests create tags and don't clean the resource after the test is ran.

Fixes #163817

@sebelga sebelga self-assigned this Aug 21, 2023
@sebelga sebelga added Feature:Saved Object Tagging Saved Objects Tagging feature Team:SharedUX Team label for AppEx-SharedUX (formerly Global Experience) labels Aug 21, 2023
@sebelga sebelga marked this pull request as ready for review August 22, 2023 09:22
@sebelga sebelga requested a review from a team as a code owner August 22, 2023 09:22
@elasticmachine
Copy link
Contributor

Pinging @elastic/appex-sharedux (Team:SharedUX)

@sebelga sebelga requested a review from Dosant August 22, 2023 09:24
@sebelga sebelga added the release_note:skip Skip the PR/issue when compiling release notes label Aug 22, 2023
@Dosant
Copy link
Contributor

Dosant commented Aug 22, 2023

@sebelga, have you run it in the flaky test runner? all good?
(I usually first commit with .only, use the runner, then remove .only, to don't waste to much time during the flaky run)

@sebelga
Copy link
Contributor Author

sebelga commented Aug 22, 2023

I usually first commit with .only, use the runner, then remove .only, to don't waste to much time during the flaky run

@Dosant : Running in isolation works fine. The problem is when ran with the other tests that can create flakiness

have you run it in the flaky test runner?

Job created: https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/2945

@sebelga
Copy link
Contributor Author

sebelga commented Aug 22, 2023

Also... this test was not skipped. So it is running on all the other PRs 😊

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @sebelga

Copy link
Contributor

@Dosant Dosant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for running the flaky runner. seems stable

@sebelga
Copy link
Contributor Author

sebelga commented Aug 22, 2023

Thanks for the review @Dosant 👍

@sebelga sebelga merged commit 635eedb into elastic:main Aug 22, 2023
@sebelga sebelga deleted the fix-bulk-delete-tags-functional-test branch August 22, 2023 12:13
@kibanamachine kibanamachine added v8.11.0 backport:skip This commit does not require backporting labels Aug 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting Feature:Saved Object Tagging Saved Objects Tagging feature release_note:skip Skip the PR/issue when compiling release notes Team:SharedUX Team label for AppEx-SharedUX (formerly Global Experience) v8.11.0
Projects
None yet
5 participants