Add a slight delay before selecting a visualization type #169851
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gsoldevila
added
Team:Core
|
100x flaky test runner ✅ |
💚 Build Succeeded
Metrics [docs]
History
To update your PR or re-run it, just comment with: cc @gsoldevila |
|
Pinging @elastic/kibana-core (Team:Core) |
|
Pinging @elastic/appex-sharedux (Team:SharedUX) |
Dosant
approved these changes
Oct 26, 2023
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Oct 26, 2023
) ## Summary Attempt at fixing elastic#89958 As per my [latest comment](elastic#89958 (comment)) on the issue, I believe that the test logic sometimes fails to select the appropriate visualisation type, in this case `Text` (aka markdown). The failure manifests [a couple of steps later](https://github.com/elastic/kibana/blob/main/x-pack/test/saved_object_tagging/functional/tests/visualize_integration.ts#L155), as this operation does not meet the expected "before state". The strategy of this fix consists in introducing an extra step, searching for the visualisation type, which should give the UI enough time to attach an event handler to the control. (cherry picked from commit 3d19006)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Oct 26, 2023
) (#169917) # Backport This will backport the following commits from `main` to `8.11`: - [Add a slight delay before selecting a visualization type (#169851)](#169851) <!--- Backport version: 8.9.7 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Gerard Soldevila","email":"[email protected]"},"sourceCommit":{"committedDate":"2023-10-26T09:50:04Z","message":"Add a slight delay before selecting a visualization type (#169851)\n\n## Summary\r\n\r\nAttempt at fixing https://github.com/elastic/kibana/issues/89958\r\n\r\nAs per my [latest\r\ncomment](https://github.com/elastic/kibana/issues/89958#issuecomment-1779553320)\r\non the issue, I believe that the test logic sometimes fails to select\r\nthe appropriate visualisation type, in this case `Text` (aka markdown).\r\n\r\nThe failure manifests [a couple of steps\r\nlater](https://github.com/elastic/kibana/blob/main/x-pack/test/saved_object_tagging/functional/tests/visualize_integration.ts#L155),\r\nas this operation does not meet the expected \"before state\".\r\n\r\nThe strategy of this fix consists in introducing an extra step,\r\nsearching for the visualisation type, which should give the UI enough\r\ntime to attach an event handler to the control.","sha":"3d19006052a33b224b03c7fbda2ed408d9a43462","branchLabelMapping":{"^v8.12.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Team:Core","release_note:skip","test-failure-flaky","Team:SharedUX","backport:prev-minor","v8.12.0"],"number":169851,"url":"https://github.com/elastic/kibana/pull/169851","mergeCommit":{"message":"Add a slight delay before selecting a visualization type (#169851)\n\n## Summary\r\n\r\nAttempt at fixing https://github.com/elastic/kibana/issues/89958\r\n\r\nAs per my [latest\r\ncomment](https://github.com/elastic/kibana/issues/89958#issuecomment-1779553320)\r\non the issue, I believe that the test logic sometimes fails to select\r\nthe appropriate visualisation type, in this case `Text` (aka markdown).\r\n\r\nThe failure manifests [a couple of steps\r\nlater](https://github.com/elastic/kibana/blob/main/x-pack/test/saved_object_tagging/functional/tests/visualize_integration.ts#L155),\r\nas this operation does not meet the expected \"before state\".\r\n\r\nThe strategy of this fix consists in introducing an extra step,\r\nsearching for the visualisation type, which should give the UI enough\r\ntime to attach an event handler to the control.","sha":"3d19006052a33b224b03c7fbda2ed408d9a43462"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v8.12.0","labelRegex":"^v8.12.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/169851","number":169851,"mergeCommit":{"message":"Add a slight delay before selecting a visualization type (#169851)\n\n## Summary\r\n\r\nAttempt at fixing https://github.com/elastic/kibana/issues/89958\r\n\r\nAs per my [latest\r\ncomment](https://github.com/elastic/kibana/issues/89958#issuecomment-1779553320)\r\non the issue, I believe that the test logic sometimes fails to select\r\nthe appropriate visualisation type, in this case `Text` (aka markdown).\r\n\r\nThe failure manifests [a couple of steps\r\nlater](https://github.com/elastic/kibana/blob/main/x-pack/test/saved_object_tagging/functional/tests/visualize_integration.ts#L155),\r\nas this operation does not meet the expected \"before state\".\r\n\r\nThe strategy of this fix consists in introducing an extra step,\r\nsearching for the visualisation type, which should give the UI enough\r\ntime to attach an event handler to the control.","sha":"3d19006052a33b224b03c7fbda2ed408d9a43462"}}]}] BACKPORT--> Co-authored-by: Gerard Soldevila <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Attempt at fixing #89958
As per my latest comment on the issue, I believe that the test logic sometimes fails to select the appropriate visualisation type, in this case
Text(aka markdown).The failure manifests a couple of steps later, as this operation does not meet the expected "before state".
The strategy of this fix consists in introducing an extra step, searching for the visualisation type, which should give the UI enough time to attach an event handler to the control.