Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[APM] Mobile APM Most used widget #143501

Closed
4 tasks done
boriskirov opened this issue Oct 18, 2022 · 5 comments · Fixed by #144232
Closed
4 tasks done

[APM] Mobile APM Most used widget #143501

boriskirov opened this issue Oct 18, 2022 · 5 comments · Fixed by #144232
Assignees
Labels
apm:mobile apm:release-feature APM UI - Release Feature Goal apm:test-plan-done Pull request that was successfully tested during the test plan Team:APM All issues that need APM UI Team support v8.6.0

Comments

@boriskirov
Copy link
Contributor

boriskirov commented Oct 18, 2022

Add a most used widget in the Mobile APM Service overview page:
Initial proposal
image

Deliver the following chars using Lens
image

  • Add new UI component in the mobile APM agent's service overview page highlighting 'Most used device', 'Most used OS', etc., similar to what has been shown in the mock-up located here

  • We've agreed to investigate if we can visualize the information in the way we have the proposed design, if not we can pick something like a pie-chart or something else.

  • We don't need to add links in the widget for now

  • Investigate lens embeddable as part of this ticket

Related to:
https://github.com/elastic/apm-dev/issues/823
Figma Design explorations
#143498

@botelastic botelastic bot added the needs-team Issues missing a team label label Oct 18, 2022
@boriskirov boriskirov added the Team:APM All issues that need APM UI Team support label Oct 18, 2022
@elasticmachine
Copy link
Contributor

Pinging @elastic/apm-ui (Team:APM)

@botelastic botelastic bot removed the needs-team Issues missing a team label label Oct 18, 2022
@dannycroft dannycroft added apm:mobile apm:release-feature APM UI - Release Feature Goal v8.6.0 labels Oct 18, 2022
@gbamparop
Copy link
Contributor

@boriskirov I believe we have discussed to investigate introducing lens embeddable for this and use a pie chart or something similar?

@boriskirov
Copy link
Contributor Author

@gbamparop It is part of the ticket description now, once you conduct the research and have the finding, let's schedule a session and discuss things.

@kpatticha kpatticha self-assigned this Oct 24, 2022
@kpatticha
Copy link
Contributor

kpatticha commented Oct 26, 2022

findings using lens embeddable:

Pros

  1. Lens embeddable allows us to create new charts fast
    i. no ned to create new endpoint
    ii. no need to create custom UI charts using EuiChart
  2. consistency across the app(s)
  3. additional actions come for free (in the example didn't work, I might miss a configuration)
    i. inspect
    ii. explore data in discover

Cons

  1. Limited visualisation options - we can use only what lens offers
  2. Limited data processing
  3. in the example, I've noticed the embeddable charts take a bit longer to render compare to the custom ones.

Next steps:

  1. create PR with the lens embeddable in use to gather feedback from the engineering team
  2. meanwhile @boriskirov we'll play with lens to find another way to present the most used values
  3. I'll reach out to agent-mobile team for more realistic data or create a synthrace scenario if possible

kpatticha added a commit that referenced this issue Nov 14, 2022
## Summary

closes #144455 

In this PR we've updated some of the initial overview experience for
Mobile APM services by:
- rearranging the panels on the Overview page for improved mobile and
APM experience
- fitting all the Most used widgets into one panel, and rearranging them
- adding a callout for feedback
- adding a technical preview badge
- update the Embeddable component visual and size


![image](https://user-images.githubusercontent.com/13353203/201143633-20b8adb4-e342-4d7f-8e87-d7b3f7e10121.png)

Related links: 
elastic/apm-dev#823
#143498
#143501
#143504

Co-authored-by: kibanamachine <[email protected]>
Co-authored-by: Kate Patticha <[email protected]>
@kpatticha
Copy link
Contributor

There is another disadvantage of using lens.

In the service overview page the user has the option to enable/disable the comparison feature.
Currently, neither map nor most users pie charts display comparison data and as far I know, lens do not support that.

This is something we need to take into consideration for the next cycle.

Thanks @dgieselaar for catching it 👍

cc @gbamparop @boriskirov

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
apm:mobile apm:release-feature APM UI - Release Feature Goal apm:test-plan-done Pull request that was successfully tested during the test plan Team:APM All issues that need APM UI Team support v8.6.0
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants