Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[APM] Small design uplifts of the Mobile APM overview page #144998

Merged
merged 6 commits into from
Nov 14, 2022
Merged

[APM] Small design uplifts of the Mobile APM overview page #144998

merged 6 commits into from
Nov 14, 2022

Conversation

boriskirov
Copy link
Contributor

@boriskirov boriskirov commented Nov 10, 2022 •
edited by kpatticha
Loading

Summary

closes #144455

In this PR we've updated some of the initial overview experience for Mobile APM services by:

  • rearranging the panels on the Overview page for improved mobile and APM experience
  • fitting all the Most used widgets into one panel, and rearranging them
  • adding a callout for feedback
  • adding a technical preview badge
  • update the Embeddable component visual and size

image

Related links:
https://github.com/elastic/apm-dev/issues/823
#143498
#143501
#143504

@boriskirov boriskirov requested a review from a team as a code owner November 10, 2022 16:01
@botelastic botelastic bot added the Team:APM All issues that need APM UI Team support label Nov 10, 2022
@elasticmachine
Copy link
Contributor

Pinging @elastic/apm-ui (Team:APM)

@boriskirov boriskirov changed the title Small design uplifts of the Mobile APM overview page [APM] Small design uplifts of the Mobile APM overview page Nov 11, 2022
@boriskirov boriskirov requested a review from kpatticha November 11, 2022 16:46
@kpatticha kpatticha added the release_note:skip Skip the PR/issue when compiling release notes label Nov 14, 2022
@kpatticha
Copy link
Contributor

In addition, I just added the missing translations and updated the snapshots

MiriamAparicio
MiriamAparicio approved these changes Nov 14, 2022
View reviewed changes
Copy link
Contributor

@MiriamAparicio MiriamAparicio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🌟

yngrdyn
yngrdyn reviewed Nov 14, 2022
View reviewed changes
...ic/components/app/service_overview/service_overview_charts/service_oveview_mobile_charts.tsx
</EuiTitle>
</EuiFlexItem>
<EuiFlexGroup direction={rowDirection} gutterSize="s">
{/* Device */}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[nit] do we need these type of comments?

@kpatticha kpatticha enabled auto-merge (squash) November 14, 2022 13:38
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
apm 3.1MB 3.1MB +1.3KB
Unknown metric groups

ESLint disabled in files

id before after diff
osquery 1 2 +1

ESLint disabled line counts

id before after diff
enterpriseSearch 19 21 +2
fleet 59 65 +6
osquery 108 113 +5
securitySolution 441 447 +6
total +19

Total ESLint disabled count

id before after diff
enterpriseSearch 20 22 +2
fleet 67 73 +6
osquery 109 115 +6
securitySolution 518 524 +6
total +20

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @kpatticha

@kpatticha kpatticha merged commit 296769a into elastic:main Nov 14, 2022
@kibanamachine kibanamachine added v8.6.0 backport:skip This commit does not require backporting labels Nov 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MiriamAparicio MiriamAparicio MiriamAparicio approved these changes

@yngrdyn yngrdyn yngrdyn approved these changes

@kpatticha kpatticha Awaiting requested review from kpatticha

Assignees

@kpatticha kpatticha

Labels
backport:skip This commit does not require backporting release_note:skip Skip the PR/issue when compiling release notes Team:APM All issues that need APM UI Team support v8.6.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[APM] Add Tech Preview badge to mobile service overview page
7 participants
@boriskirov @elasticmachine @kpatticha @kibana-ci @yngrdyn @MiriamAparicio @kibanamachine