-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[APM] Replace Lens embeddable charts used for mobile services #152139
Comments
Pinging @elastic/apm-ui (Team:APM) |
@gbamparop @kpatticha Can you confirm the following behaviour.
|
This is only available with lens embeddable so we won't have it with elastic charts.
The ones above seem like donut charts. @boriskirov would you rather have something else instead now that we're moving away from the embeddables? We've discussed custom charts before but I think it's good to pick one which is available in elastic-charts. |
I added the Figma link in the ticket description as a reference. In the mockups, the following components were suggested. UX solution uses similar components and we might able to reuse the component. it seems it is defined. kibana/x-pack/plugins/observability/public/components/shared/core_web_vitals/core_vital_item.tsx Line 77 in 70fe1a8
I suggest, if we can reuse the component to go in that direction otherwise we can explore more straightforward alternative. |
@gbamparop Can you add the reasoning for replacing lens embeddables with elastic charts? In general we want to move towards embeddables because users requests it (enables them to modify the visualisations) so there should be good reasons for moving away from them. |
That was our intention when we started introducing charts for mobile, as @kpatticha mentions above after some analysis we have discussed with the team and decided to use custom charts instead. I think one of the main reasons is the support for comparisons so although introducing this functionality is not part of this issue, it'll be great if we pick a chart type where the design team has a path forwards about where the comparisons should be displayed. |
@boriskirov Can you help us here picking the right chart based on the provided comments above ? |
@isaclfreire I just realised that Boris is on PTO, could you help us here ? |
Currently the Most Used Devices section only display the top 5 items and the percentage is summed up for those 5 devices to a 100%. As discussed with @akhileshpok, we will also display Also @akhileshpok confirmed we will not be displaying comparisons on this chart. Hence i will add the tooltip, @isaclfreire In that case the only feedback i need from you is to choose the right chart for this implementation, i believe this is the one which we will be using - https://elastic.github.io/elastic-charts/?path=/story/sunburst--with-direct-text-labels&globals=theme:light cc: @gbamparop @kpatticha |
## Summary This PR closes #152139 This change brings a big performance improvement in Loading of the Charts ### Checklist - [x] Add new endpoint to retrieve filtered data based on URL params - [x] Replace Embeddables with Elastic Charts - [x] Delete existing code for Embeddables - [x] Handle Loaders - [x] Add similar No results found visualisations - [x] Add Cy Tests - [x] Add API Tests ## Demo https://user-images.githubusercontent.com/7416358/232797685-1b009d5d-cd4a-4041-aa33-872647491ced.mov --------- Co-authored-by: kibanamachine <[email protected]>
The charts loads properly though i have my concerns around the data. @sqren @dgieselaar I compared the queries fired by us and by lens team to get Most Used Charts for Device Identifier (just one example). I see a difference in response for the chart values The difference i see is we filter the terms by "processor.event": ["transaction"] and must query for Due to that the difference in response is present. Is my assumption correct that our new queries are correct compared to what we were passing to Lens previously and that i can mark this as done ? |
@achyutjhunjhunwala Thanks for the thorough testing! Do you get the same numbers if you remove the filters It sounds right that those filters should be applied so it was probably a (small) bug that they weren't in the Lens implementation. |
Not exact, but closer. I will mark this ticket test done in that case |
In 8.6 we have introduced the following charts for mobile services using Lens embeddables:
A stretch goal for 8.8 will be to replace the lens embeddables with elastic-charts.
Links
The text was updated successfully, but these errors were encountered: