Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace lens embeddable for most used charts #155026

Conversation

achyutjhunjhunwala
Copy link
Contributor

@achyutjhunjhunwala achyutjhunjhunwala commented Apr 17, 2023

Summary

This PR closes #152139

This change brings a big performance improvement in Loading of the Charts

Checklist

  • Add new endpoint to retrieve filtered data based on URL params
  • Replace Embeddables with Elastic Charts
  • Delete existing code for Embeddables
  • Handle Loaders
  • Add similar No results found visualisations
  • Add Cy Tests
  • Add API Tests

Demo

Screen.Recording.2023-04-18.at.15.46.58.mov

@apmmachine
Copy link
Contributor

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with:

  • /oblt-deploy : Deploy a Kibana instance using the Observability test environments.
  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@achyutjhunjhunwala
Copy link
Contributor Author

/oblt-deploy

@achyutjhunjhunwala
Copy link
Contributor Author

/oblt-deploy

@achyutjhunjhunwala
Copy link
Contributor Author

/oblt-deploy

@achyutjhunjhunwala
Copy link
Contributor Author

/oblt-deploy

@achyutjhunjhunwala
Copy link
Contributor Author

/oblt-deploy

@achyutjhunjhunwala achyutjhunjhunwala marked this pull request as ready for review April 18, 2023 14:34
@achyutjhunjhunwala achyutjhunjhunwala requested a review from a team as a code owner April 18, 2023 14:35
@botelastic botelastic bot added the Team:APM All issues that need APM UI Team support label Apr 18, 2023
@achyutjhunjhunwala
Copy link
Contributor Author

/oblt-deploy

@achyutjhunjhunwala
Copy link
Contributor Author

/oblt-deploy

Copy link
Contributor

@yngrdyn yngrdyn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀 , just some minor comments

@kibana-ci
Copy link
Collaborator

💛 Build succeeded, but was flaky

Failed CI Steps

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
apm 1275 1313 +38

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
apm 3.4MB 3.4MB +1.3KB

Public APIs missing exports

Total count of every type that is part of your API that should be exported but is not. This will cause broken links in the API documentation system. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats exports for more detailed information.

id before after diff
apm 109 110 +1
Unknown metric groups

ESLint disabled line counts

id before after diff
securitySolution 394 397 +3

Total ESLint disabled count

id before after diff
securitySolution 474 477 +3

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @achyutjhunjhunwala

@achyutjhunjhunwala achyutjhunjhunwala merged commit 4b6dbdc into elastic:main Apr 20, 2023
@kibanamachine kibanamachine added the backport:skip This commit does not require backporting label Apr 20, 2023
@achyutjhunjhunwala achyutjhunjhunwala deleted the replace-lens-embeddable-for-most-used-charts branch April 20, 2023 12:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting release_note:enhancement Team:APM All issues that need APM UI Team support v8.8.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[APM] Replace Lens embeddable charts used for mobile services
7 participants