-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace lens embeddable for most used charts #155026
Replace lens embeddable for most used charts #155026
Conversation
🤖 GitHub commentsExpand to view the GitHub comments
Just comment with:
|
/oblt-deploy |
/oblt-deploy |
/oblt-deploy |
/oblt-deploy |
/oblt-deploy |
/oblt-deploy |
/oblt-deploy |
x-pack/plugins/apm/server/routes/mobile/get_mobile_most_used_charts/get_device_os_app_charts.ts
Outdated
Show resolved
Hide resolved
.../ftr_e2e/cypress/e2e/power_user/service_overview/mobile_overview_with_most_used_charts.cy.ts
Outdated
Show resolved
Hide resolved
.../ftr_e2e/cypress/e2e/power_user/service_overview/mobile_overview_with_most_used_charts.cy.ts
Show resolved
Hide resolved
...lugins/apm/public/components/app/mobile/service_overview/most_used_charts/sunburst_chart.tsx
Outdated
Show resolved
Hide resolved
...lugins/apm/public/components/app/mobile/service_overview/most_used_charts/sunburst_chart.tsx
Outdated
Show resolved
Hide resolved
...lugins/apm/public/components/app/mobile/service_overview/most_used_charts/sunburst_chart.tsx
Outdated
Show resolved
Hide resolved
...lugins/apm/public/components/app/mobile/service_overview/most_used_charts/sunburst_chart.tsx
Show resolved
Hide resolved
x-pack/test/apm_api_integration/tests/mobile/mobile_most_used_chart.spec.ts
Show resolved
Hide resolved
x-pack/test/apm_api_integration/tests/mobile/mobile_most_used_chart.spec.ts
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀 , just some minor comments
💛 Build succeeded, but was flaky
Failed CI StepsMetrics [docs]Module Count
Async chunks
Public APIs missing exports
Unknown metric groupsESLint disabled line counts
Total ESLint disabled count
History
To update your PR or re-run it, just comment with: |
Summary
This PR closes #152139
This change brings a big performance improvement in Loading of the Charts
Checklist
Demo
Screen.Recording.2023-04-18.at.15.46.58.mov