Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Cases] User assignment enhancements #141057

Open
10 of 25 tasks
cnasikas opened this issue Sep 20, 2022 · 4 comments
Open
10 of 25 tasks

[Cases] User assignment enhancements #141057

cnasikas opened this issue Sep 20, 2022 · 4 comments
Labels
Feature:Cases Cases feature Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams)

Comments

@cnasikas
Copy link
Member

cnasikas commented Sep 20, 2022

In #140208 we introduced the ability to assign users to a case. This issue describes various enhancements that can become to improve UX and testing. Specifically:

@cnasikas cnasikas added Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) Feature:Cases Cases feature labels Sep 20, 2022
@elasticmachine
Copy link
Contributor

Pinging @elastic/response-ops-cases (Feature:Cases)

@elasticmachine
Copy link
Contributor

Pinging @elastic/response-ops (Team:ResponseOps)

jonathan-buttner added a commit that referenced this issue Nov 14, 2022
WIP

This PR implements some enhancements for the assignees feature that
wasn't completed in 8.5.

Issue: #141057
Fixes: #140889

### List sorting

The current user is not brought to the front of lists (only in the
popovers). Unknown users are still placed at the end of the list.

<details><summary>Current user is sorted like other users</summary>

#### Case View Page


![image](https://user-images.githubusercontent.com/56361221/200646181-9744622f-fe11-41c5-97ac-ce7b777d47a1.png)

#### Case List Page Avatars


![image](https://user-images.githubusercontent.com/56361221/200646269-b637743f-35f1-48d0-91bd-faee32784613.png)


</details>

### Limit assignee selection

Leverage the `limit` prop exposed by the `UserProfilesSelectable` here:
#144618

<details><summary>Adding limit message</summary>


![image](https://user-images.githubusercontent.com/56361221/200653672-9c195031-3117-4ac9-b6e9-98ac11ee170e.png)


</details>

### Show the selected count

Show the selected count even when it is zero so the component doesn't
jump around.

<details><summary>Selected count</summary>

#### View case page


![image](https://user-images.githubusercontent.com/56361221/200659972-a6eca466-0d4c-4736-9a2e-62b422f99944.png)

#### All cases filter


![image](https://user-images.githubusercontent.com/56361221/200660181-da13092b-6f6a-4b2d-98cd-325ebf8d75b1.png)


</details>

### Expandable assignees column

Added a button to expand/collapse the assignee avatars column on the all
cases list page

<details><summary>Cases list page assignees column</summary>


![image](https://user-images.githubusercontent.com/56361221/200891826-08f15531-3a47-40c1-9cc6-12558b645083.png)


![image](https://user-images.githubusercontent.com/56361221/200892014-92cd3142-15d0-4250-b83e-b32b1c9dd03f.png)


</details>

Co-authored-by: Kibana Machine <[email protected]>
@jonathan-buttner
Copy link
Contributor

Use UserToolTip and UserAvatarTip from security.

I looked into this one a bit, looks like the sizing for the text and the avatar is different that what we use. Should we ask them to make it configurable?

Specifically:

@cnasikas
Copy link
Member Author

cnasikas commented Jan 30, 2023

I think it will be faster if we do the changes to the security component ourselves. They seem trivial.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature:Cases Cases feature Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams)
Projects
None yet
Development

No branches or pull requests

3 participants