Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add the ability to limit the number of users you can select #144618

Merged
merged 2 commits into from
Nov 7, 2022
Merged

Add the ability to limit the number of users you can select #144618

merged 2 commits into from
Nov 7, 2022

Conversation

thomheymann
Copy link
Contributor

@thomheymann thomheymann commented Nov 4, 2022 •
edited by watson
Loading

Resolves #140889

Screenshot

Screenshot 2022-11-04 at 14 20 56

Testing

  1. yarn start --run-examples
  2. Open: http://localhost:5601/app/userProfileExamples

@thomheymann thomheymann added Team:Security Team focused on: Auth, Users, Roles, Spaces, Audit Logging, and more! release_note:skip Skip the PR/issue when compiling release notes backport:skip This commit does not require backporting Feature:Security/User Profile v8.6.0 labels Nov 4, 2022
@thomheymann thomheymann marked this pull request as ready for review November 4, 2022 15:42
@thomheymann thomheymann requested a review from a team as a code owner November 4, 2022 15:42
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-security (Team:Security)

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
cases 334.3KB 334.8KB +549.0B
security 544.7KB 544.6KB -24.0B
total +525.0B
Unknown metric groups

API count

id before after diff
@kbn/user-profile-components 55 58 +3

ESLint disabled in files

id before after diff
osquery 1 2 +1

ESLint disabled line counts

id before after diff
@kbn/user-profile-components 2 3 +1
enterpriseSearch 19 21 +2
fleet 58 64 +6
osquery 108 113 +5
securitySolution 440 446 +6
total +20

Total ESLint disabled count

id before after diff
@kbn/user-profile-components 2 3 +1
enterpriseSearch 20 22 +2
fleet 66 72 +6
osquery 109 115 +6
securitySolution 517 523 +6
total +21

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@thomheymann thomheymann merged commit a7976e5 into elastic:main Nov 7, 2022
@jonathan-buttner jonathan-buttner mentioned this pull request Nov 8, 2022
Merged
jonathan-buttner added a commit that referenced this pull request Nov 14, 2022
@jonathan-buttner @kibanamachine
[Cases] Assignees enhancements (#144836)
1e77d8d 
WIP

This PR implements some enhancements for the assignees feature that
wasn't completed in 8.5.

Issue: #141057
Fixes: #140889

### List sorting

The current user is not brought to the front of lists (only in the
popovers). Unknown users are still placed at the end of the list.

<details><summary>Current user is sorted like other users</summary>

#### Case View Page


![image](https://user-images.githubusercontent.com/56361221/200646181-9744622f-fe11-41c5-97ac-ce7b777d47a1.png)

#### Case List Page Avatars


![image](https://user-images.githubusercontent.com/56361221/200646269-b637743f-35f1-48d0-91bd-faee32784613.png)


</details>

### Limit assignee selection

Leverage the `limit` prop exposed by the `UserProfilesSelectable` here:
#144618

<details><summary>Adding limit message</summary>


![image](https://user-images.githubusercontent.com/56361221/200653672-9c195031-3117-4ac9-b6e9-98ac11ee170e.png)


</details>

### Show the selected count

Show the selected count even when it is zero so the component doesn't
jump around.

<details><summary>Selected count</summary>

#### View case page


![image](https://user-images.githubusercontent.com/56361221/200659972-a6eca466-0d4c-4736-9a2e-62b422f99944.png)

#### All cases filter


![image](https://user-images.githubusercontent.com/56361221/200660181-da13092b-6f6a-4b2d-98cd-325ebf8d75b1.png)


</details>

### Expandable assignees column

Added a button to expand/collapse the assignee avatars column on the all
cases list page

<details><summary>Cases list page assignees column</summary>


![image](https://user-images.githubusercontent.com/56361221/200891826-08f15531-3a47-40c1-9cc6-12558b645083.png)


![image](https://user-images.githubusercontent.com/56361221/200892014-92cd3142-15d0-4250-b83e-b32b1c9dd03f.png)


</details>

Co-authored-by: Kibana Machine <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@watson watson watson approved these changes

Assignees
No one assigned
Labels
backport:skip This commit does not require backporting Feature:Security/User Profile release_note:skip Skip the PR/issue when compiling release notes Team:Security Team focused on: Auth, Users, Roles, Spaces, Audit Logging, and more! v8.6.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[UserProfiles] Add the ability to limit the number of users you can select
4 participants
@thomheymann @elasticmachine @kibana-ci @watson