[ResponseOps][Cases] User assignment #140208

jonathan-buttner · 2022-09-07T16:11:03Z

This PR contains the user assignments feature for cases. We have not addressed the feedback noted here:
#139039

This PR encompasses the following PRs that have individually reviewed:
#139441 (Filtering on the cases list page)
#139392 (User activity feed)
#139754 (Support assignment during creation flow)
#138108 (Assigning a user in the single case view)

We will address the user avatars, participants section, licensing and other design improvements in separate PRs to the main branch after this PR is merged.

Examples

Assign and Filtering

feature.branch.demo.mov

Release Notes

This PR allows users to assign users to cases. Multiple users can be assigned to a case. On the case list page, cases can be filtered using assignees. Cases can be assigned on the single case view page or in the case creation flow.

* Add reusable user profile selector component * Refactoring services, auth * Adding suggest api and tests * Move to package and add examples * [CI] Auto-commit changed files from 'node scripts/eslint --no-cache --fix' * Working integration tests * Switching suggest api tags * Adding assignees field * Adding tests for size and owner * Add server side example * CI Fixes * Adding assignee integration tests * fix tests * Addd tests * Starting user actions changes * Adding api tag tests * Addressing feedback * Using lodash for array comparison logic and tests * Fixing type error * Create suggest query * Adding assignees user action * [ResponseOps][Cases] Refactoring client args and authentication (#137345) * Refactoring services, auth * Fixing type errors * Adding assignees migration and tests * Fixing types and added more tests * Fixing cypress test * Fixing test * Add tests * Add security as dependency and fix types * Add bulk get profiles query * Rename folder * Addressed suggestions from code review * Fix types * Adding migration for assignees field and tests * Adding comments and a few more tests * Updating comments and spelling * Revert security solution optional * PR feedback * Updated user avatar component * Reduce size * Make security required * Fix tests * Addressing feedback * Do not retry suggestions * Assign users to a case * Restructure components * Move assignees to case view * Show assigned users * Refactoring bulk get and display name * Adding tests for user tooltip * Adding tests * Hovering and tests * Fixing errors * Some pr clean up * Fixing tests and adding more * Adding functional tests * Fixing jest test failure * Passing in current user profile * Refactoring assignment with useEffect * Fixing icon alignment and removal render bug * Fixing type errors * Fixing test errors * Adding bulk get privs and tests * Fixing popover tests * Handling unknown users * Adding tests for unknown users * Adding wait for popover calls * Addressing design feedback * Addressing remaining feedback * Refactoring css and name prop * Refactoring popover * Refactoring search component * Addressing some feedback * Adjusting sorting * Fixing tests * Fixing type error * Fixing test error * Fixing test errors * Removing display name Co-authored-by: Thom Heymann <[email protected]> Co-authored-by: Jonathan Buttner <[email protected]> Co-authored-by: kibanamachine <[email protected]> Co-authored-by: Thom Heymann <[email protected]> Co-authored-by: Jonathan Buttner <[email protected]>

…gnment

* Adding user actions for assignees * Fixing merge issues * Fixing test mock errors * Fixing display name errors and themselves * Fixing test for time being * Addressing feedback * Addressing comma and uniq feedback * Using core getUserDisplayName * Fixing import and removing flickering * Fixing tests Co-authored-by: Kibana Machine <[email protected]>

…gnment

…o cases-user-assignment

…gnment

* Init * Render users * Assign yourself * Add tests * Fix tests * PR feedback

* Starting the filtering * Rough draft working for assignees filtering * Adding integration tests for new route * Starting to write tests * Fixing tests * Cleaning up more tests * Removing duplicate call for current user * Fixing type errors and tests * Adding tests for filtering * Adding rbac tests * Fixing translations * Fixing api integration tests * Fixing severity tests * Really fixing arrays equal * Fixing ml tests and refactoring find assignees * Fixing cypress tests * Fixing types * Fix tests * Addressing first round of feedback * Reverting the recent cases changes * Fixing tests * Fixing more tests and types * Allowing multi select * Fixing attachment framework issue * Addressing feedback

…gnment

elasticmachine · 2022-09-07T20:30:08Z

Pinging @elastic/response-ops (Team:ResponseOps)

elasticmachine · 2022-09-07T20:30:10Z

Pinging @elastic/response-ops-cases (Feature:Cases)

MadameSheema

security-engineering-productivity changes LGTM

darnautov

ML changes LGTM

jonathan-buttner · 2022-09-08T12:58:47Z

@elasticmachine merge upstream

jamster10

Good to go from a Security Solution standpoint ✅

peteharverson · 2022-09-08T14:55:28Z

Logging in as a user with Read privilege on Cases (all 3 solutions), I see this error from the suggest_user_profiles call:

x-pack/plugins/cases/public/components/case_view/components/assign_users.tsx

kc13greiner · 2022-09-08T19:27:20Z

x-pack/plugins/cases/public/components/create/assignees.tsx

+        labelAppend={OptionalFieldLabel}
+        helpText={
+          <EuiLink data-test-subj="create-case-assign-yourself-link" onClick={onSelfAssign}>
+            {i18n.ASSIGN_YOURSELF}


Assign Yourself link is available even when creating a Case as a User that does not have a User Profile, such as when using the Anonymous Authentication Provider

This link is correctly hidden on the Edit Case view and should probably be hidden here as well.

Oops, thanks for catching that!

peteharverson

Tested latest changes and LGTM

legrego

Changes for platform security LGTM - great work!

As discussed offline, I think it would be beneficial to hide the user assignment ux if security is disabled in Elasticsearch. That shouldn't block this PR from merging though.

jonathan-buttner · 2022-09-09T13:58:02Z

@elasticmachine merge upstream

cnasikas · 2022-09-12T07:41:50Z

@elasticmachine merge upstream

cnasikas

I have reviewed all PRs that are merged in this PR. I tested and it is looking good to me. Great job 🚀 !

kibana-ci · 2022-09-12T09:53:14Z

💚 Build Succeeded

Buildkite Build
Commit: 50e417a

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id	before	after	diff
`cases`	460	484	+24

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id	before	after	diff
`cases`	344.4KB	366.6KB	+22.2KB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id	before	after	diff
`cases`	122.9KB	123.0KB	+115.0B

Unknown metric groups

async chunk count

id	before	after	diff
`cases`	16	17	+1

ESLint disabled in files

id	before	after	diff
`cases`	15	16	+1

ESLint disabled line counts

id	before	after	diff
`cases`	68	67	-1

History

💚 Build #71119 succeeded 45829cd
💚 Build #70852 succeeded 854523f
💔 Build #70657 failed 63ca0a7
💚 Build #70585 succeeded d85963e
💚 Build #70527 succeeded 6b24a17
💚 Build #70425 succeeded 49f2a54

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

MichaelMarcialis · 2022-09-12T16:01:47Z

Excellent work here, @jonathan-buttner and @cnasikas! I'm a bit late to the party, but did have one note regarding the assignee count in both the filter and assignees popovers.

When there are no assignees on a case or no assignees being filtered, both assignee and assignee filter popovers currently hide the selected count. This can cause the popover to jump around visually. Can we instead always show the assignee count in these two popovers even when the count is zero (0 assigned and 0 assignees filtered respectively)? I know we went back and forth on this a few times, because we previously thought we might be able to include a total count of all available assignees (which would prevent the row of text from being removed entirely and thus prevent the popover jumping). However, since that didn't work out ultimately, I think added back the count when at zero makes sense again.

jonathan-buttner · 2022-09-12T18:09:39Z

@MichaelMarcialis sounds good will do!

cnasikas and others added 12 commits August 24, 2022 11:26

Merge branch 'main' of github.com:elastic/kibana into cases-user-assi…

939f52b

…gnment

Merge branch 'main' of github.com:elastic/kibana into cases-user-assi…

15f2279

…gnment

Merge branch 'cases-user-assignment' of github.com:elastic/kibana int…

1c4942f

…o cases-user-assignment

Merge branch 'main' of github.com:elastic/kibana into cases-user-assi…

622fbdc

…gnment

Merge branch 'main' into cases-user-assignment

0657743

Detect when user is typing

301770e

Use select to tranform data

8103bd3

[Cases] Assign users when creating a case (#139754)

01006bf

* Init * Render users * Assign yourself * Add tests * Fix tests * PR feedback

Merge branch 'main' of github.com:elastic/kibana into cases-user-assi…

41a44c6

…gnment

jonathan-buttner added Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) Feature:Cases Cases feature release_note:feature Makes this part of the condensed release notes v8.5.0 labels Sep 7, 2022

jonathan-buttner added 2 commits September 7, 2022 12:36

Fixing type error

da1b4a8

Fixing tests

80f847f

jonathan-buttner marked this pull request as ready for review September 7, 2022 20:30

jonathan-buttner requested review from a team as code owners September 7, 2022 20:30

jonathan-buttner mentioned this pull request Sep 7, 2022

[ResponseOps][Cases] Align case avatars #140227

Merged

MadameSheema approved these changes Sep 8, 2022

View reviewed changes

cnasikas added 2 commits September 8, 2022 11:37

Sort users and improve loading

729f072

Fix ml security dependecies

57beeef

cnasikas requested a review from darnautov September 8, 2022 09:51

darnautov approved these changes Sep 8, 2022

View reviewed changes

Merge branch 'main' into cases-user-assignment

49f2a54

jamster10 approved these changes Sep 8, 2022

View reviewed changes

peteharverson reviewed Sep 8, 2022

View reviewed changes

x-pack/plugins/cases/public/components/case_view/components/assign_users.tsx Outdated Show resolved Hide resolved

Fixing read permissions and suggest api

6b24a17

legrego requested review from kc13greiner and legrego September 8, 2022 16:14

Hiding assignee delete icon

d85963e

kc13greiner reviewed Sep 8, 2022

View reviewed changes

Hiding the assign yourself text when undefined

63ca0a7

peteharverson approved these changes Sep 9, 2022

View reviewed changes

legrego approved these changes Sep 9, 2022

View reviewed changes

Merge branch 'main' into cases-user-assignment

854523f

kibanamachine and others added 2 commits September 12, 2022 01:41

Merge branch 'main' into cases-user-assignment

45829cd

Create page fixes

50e417a

cnasikas approved these changes Sep 12, 2022

View reviewed changes

jonathan-buttner merged commit e5cc558 into main Sep 12, 2022

jonathan-buttner deleted the cases-user-assignment branch September 12, 2022 11:37

kibanamachine added the backport:skip This commit does not require backporting label Sep 12, 2022

This was referenced Sep 19, 2022

[Cases] Push case assignees to external incident management services #140920

Open

[Cases] User assignment enhancements #141057

Open

cnasikas mentioned this pull request Nov 16, 2022

[RAC] design update for the cases table view #110214

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[ResponseOps][Cases] User assignment #140208

[ResponseOps][Cases] User assignment #140208

jonathan-buttner commented Sep 7, 2022 •

edited

Loading

elasticmachine commented Sep 7, 2022

elasticmachine commented Sep 7, 2022

MadameSheema left a comment

darnautov left a comment

jonathan-buttner commented Sep 8, 2022

jamster10 left a comment

peteharverson commented Sep 8, 2022

kc13greiner Sep 8, 2022

jonathan-buttner Sep 8, 2022

jonathan-buttner Sep 8, 2022

peteharverson left a comment

legrego left a comment

jonathan-buttner commented Sep 9, 2022

cnasikas commented Sep 12, 2022

cnasikas left a comment •

edited

Loading

kibana-ci commented Sep 12, 2022

async chunk count

ESLint disabled in files

ESLint disabled line counts

MichaelMarcialis commented Sep 12, 2022 •

edited

Loading

jonathan-buttner commented Sep 12, 2022

[ResponseOps][Cases] User assignment #140208

[ResponseOps][Cases] User assignment #140208

Conversation

jonathan-buttner commented Sep 7, 2022 • edited Loading

Examples

Release Notes

elasticmachine commented Sep 7, 2022

elasticmachine commented Sep 7, 2022

MadameSheema left a comment

Choose a reason for hiding this comment

darnautov left a comment

Choose a reason for hiding this comment

jonathan-buttner commented Sep 8, 2022

jamster10 left a comment

Choose a reason for hiding this comment

peteharverson commented Sep 8, 2022

kc13greiner Sep 8, 2022

Choose a reason for hiding this comment

jonathan-buttner Sep 8, 2022

Choose a reason for hiding this comment

jonathan-buttner Sep 8, 2022

Choose a reason for hiding this comment

peteharverson left a comment

Choose a reason for hiding this comment

legrego left a comment

Choose a reason for hiding this comment

jonathan-buttner commented Sep 9, 2022

cnasikas commented Sep 12, 2022

cnasikas left a comment • edited Loading

Choose a reason for hiding this comment

kibana-ci commented Sep 12, 2022

💚 Build Succeeded

Metrics [docs]

Module Count

Async chunks

Page load bundle

async chunk count

ESLint disabled in files

ESLint disabled line counts

History

MichaelMarcialis commented Sep 12, 2022 • edited Loading

jonathan-buttner commented Sep 12, 2022

jonathan-buttner commented Sep 7, 2022 •

edited

Loading

cnasikas left a comment •

edited

Loading

MichaelMarcialis commented Sep 12, 2022 •

edited

Loading