Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added user avatar tooltip #142162

Merged
merged 3 commits into from
Oct 3, 2022
Merged

Added user avatar tooltip #142162

merged 3 commits into from
Oct 3, 2022

Conversation

thomheymann
Copy link
Contributor

@thomheymann thomheymann commented Sep 28, 2022

Resolves #137276

Summary

Adds the following shared components

  • UserToolTip - Renders a tooltip with user information
  • UserAvatarTip - Renders a user avatar with tooltip

Screenshot

Screenshot 2022-09-29 at 08 33 37

Usage

import { UserToolTip, UserAvatarTip } from '@kbn/user-profile-components';

<UserToolTip user={userProfile.user} avatar={userProfile.data.avatar}>
  <!-- An inline element to trigger the tooltip -->
</UserToolTip>

<UserAvatarTip user={userProfile.user} avatar={userProfile.data.avatar} />

@thomheymann thomheymann added Team:Security Team focused on: Auth, Users, Roles, Spaces, Audit Logging, and more! v8.6.0 Feature:Security/User Profile backport:skip This commit does not require backporting release_note:skip Skip the PR/issue when compiling release notes labels Sep 29, 2022
@thomheymann thomheymann marked this pull request as ready for review September 29, 2022 09:08
@thomheymann thomheymann requested a review from a team as a code owner September 29, 2022 09:08
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-security (Team:Security)

@kc13greiner kc13greiner self-requested a review October 3, 2022 11:27
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
cases 496 498 +2
security 461 463 +2
total +4

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id before after diff
@kbn/user-profile-components 3 5 +2

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
cases 371.0KB 371.0KB +24.0B
Unknown metric groups

API count

id before after diff
@kbn/user-profile-components 48 55 +7

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

Copy link
Contributor

@kc13greiner kc13greiner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@thomheymann thomheymann merged commit 44b3863 into elastic:main Oct 3, 2022
WafaaNasr pushed a commit to WafaaNasr/kibana that referenced this pull request Oct 11, 2022
* Added user avatar tooltip

* Updated js docs
WafaaNasr pushed a commit to WafaaNasr/kibana that referenced this pull request Oct 14, 2022
* Added user avatar tooltip

* Updated js docs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting Feature:Security/User Profile release_note:skip Skip the PR/issue when compiling release notes Team:Security Team focused on: Auth, Users, Roles, Spaces, Audit Logging, and more! v8.6.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create sharable User Profile Tooltip & Avatar
4 participants