-
Notifications
You must be signed in to change notification settings - Fork 24.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deprecate client.type #104574
Merged
elasticsearchmachine
merged 5 commits into
elastic:main
from
rjernst:clienttype/deprecate
Feb 6, 2024
Merged
Deprecate client.type #104574
elasticsearchmachine
merged 5 commits into
elastic:main
from
rjernst:clienttype/deprecate
Feb 6, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
client.type existed from the days of the node client existing alongside the java client. Since the node client no longer exists, it no longer serves a purpose, and is already ignored. Yet the setting still exists. This commit deprecates the client.type node setting.
rjernst
added
:Core/Infra/Core
Core issues without another label
>deprecation
v8.13.0
labels
Jan 19, 2024
Pinging @elastic/es-core-infra (Team:Core/Infra) |
Hi @rjernst, I've created a changelog YAML for you. Note that since this PR is labelled |
ldematte
approved these changes
Jan 22, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
rjernst
added
the
auto-merge-without-approval
Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!)
label
Feb 6, 2024
rjernst
added a commit
to rjernst/elasticsearch
that referenced
this pull request
Dec 6, 2024
The client.type setting is a holdover from the node client which was removed in 8.0. The setting has been a noop since 8.0. This commit removes the setting. relates elastic#104574
rjernst
added a commit
that referenced
this pull request
Dec 9, 2024
The client.type setting is a holdover from the node client which was removed in 8.0. The setting has been a noop since 8.0. This commit removes the setting. relates #104574
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
auto-merge-without-approval
Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!)
:Core/Infra/Core
Core issues without another label
>deprecation
Team:Core/Infra
Meta label for core/infra team
v8.13.0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
client.type existed from the days of the node client existing alongside the java client. Since the node client no longer exists, it no longer serves a purpose, and is already ignored. Yet the setting still exists. This commit deprecates the client.type node setting.