Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove client.type setting #118192

Merged
merged 5 commits into from
Dec 9, 2024
Merged

Remove client.type setting #118192

merged 5 commits into from
Dec 9, 2024

Conversation

rjernst
Copy link
Member

@rjernst rjernst commented Dec 6, 2024

The client.type setting is a holdover from the node client which was removed in 8.0. The setting has been a noop since 8.0. This commit removes the setting.

relates #104574

The client.type setting is a holdover from the node client which was
removed in 8.0. The setting has been a noop since 8.0. This commit
removes the setting.

relates elastic#104574
@rjernst rjernst added >breaking :Core/Infra/Core Core issues without another label labels Dec 6, 2024
@rjernst rjernst requested a review from a team as a code owner December 6, 2024 20:41
@elasticsearchmachine elasticsearchmachine added Team:Core/Infra Meta label for core/infra team v9.0.0 labels Dec 6, 2024
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-core-infra (Team:Core/Infra)

@elasticsearchmachine
Copy link
Collaborator

Hi @rjernst, I've created a changelog YAML for you. Note that since this PR is labelled >breaking, you need to update the changelog YAML to fill out the extended information sections.

Copy link
Contributor

@ldematte ldematte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rjernst rjernst merged commit 22a392f into elastic:main Dec 9, 2024
16 checks passed
@rjernst rjernst deleted the remove_client_type branch December 9, 2024 15:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
>breaking :Core/Infra/Core Core issues without another label Team:Core/Infra Meta label for core/infra team v9.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants