Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate client.type #104574

Merged
merged 5 commits into from
Feb 6, 2024
Merged

Deprecate client.type #104574

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
5742210
Deprecate client.type
rjernst Jan 19, 2024
49b1255
Update docs/changelog/104574.yaml
rjernst Jan 19, 2024
3254803
update changelog
rjernst Jan 19, 2024
47c7765
set deprecation area
rjernst Jan 19, 2024
e4a1fd6
Merge branch 'main' into clienttype/deprecate
rjernst Feb 6, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions docs/changelog/104574.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
pr: 104574
summary: Deprecate `client.type`
area: Infra/Core
type: deprecation
issues: []
deprecation:
title: Deprecate `client.type`
area: Cluster and node setting
details: The node setting `client.type` has been ignored since the node client was removed in 8.0. The setting is now deprecated and will be removed in a future release.
impact: Remove the `client.type` setting from `elasticsearch.yml`
2 changes: 1 addition & 1 deletion server/src/main/java/org/elasticsearch/client/internal/Client.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,7 +78,7 @@ public interface Client extends ElasticsearchClient {
case "node", "transport" -> s;
default -> throw new IllegalArgumentException("Can't parse [client.type] must be one of [node, transport]");
};
}, Property.NodeScope);
}, Property.NodeScope, Property.Deprecated);

/**
* The admin client that can be used to perform administrative operations.
Expand Down