Skip to content

Commit

Permalink
Deprecate client.type (#104574)
Browse files Browse the repository at this point in the history
client.type existed from the days of the node client existing alongside
the java client. Since the node client no longer exists, it no longer
serves a purpose, and is already ignored. Yet the setting still exists.
This commit deprecates the client.type node setting.
  • Loading branch information
rjernst authored Feb 6, 2024
1 parent e8c2f4f commit b1e2cb8
Show file tree
Hide file tree
Showing 2 changed files with 11 additions and 1 deletion.
10 changes: 10 additions & 0 deletions docs/changelog/104574.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
pr: 104574
summary: Deprecate `client.type`
area: Infra/Core
type: deprecation
issues: []
deprecation:
title: Deprecate `client.type`
area: Cluster and node setting
details: The node setting `client.type` has been ignored since the node client was removed in 8.0. The setting is now deprecated and will be removed in a future release.
impact: Remove the `client.type` setting from `elasticsearch.yml`
Original file line number Diff line number Diff line change
Expand Up @@ -78,7 +78,7 @@ public interface Client extends ElasticsearchClient {
case "node", "transport" -> s;
default -> throw new IllegalArgumentException("Can't parse [client.type] must be one of [node, transport]");
};
}, Property.NodeScope);
}, Property.NodeScope, Property.Deprecated);

/**
* The admin client that can be used to perform administrative operations.
Expand Down

0 comments on commit b1e2cb8

Please sign in to comment.