-
Notifications
You must be signed in to change notification settings - Fork 121
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: custom annotation tooltip #727
feat: custom annotation tooltip #727
Conversation
Codecov Report
@@ Coverage Diff @@
## master #727 +/- ##
==========================================
+ Coverage 74.19% 74.48% +0.29%
==========================================
Files 267 282 +15
Lines 8599 8921 +322
Branches 1737 1788 +51
==========================================
+ Hits 6380 6645 +265
- Misses 2169 2220 +51
- Partials 50 56 +6
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
# [19.8.0](v19.7.0...v19.8.0) (2020-07-06) ### Bug Fixes * set uninitialized state when removeSpec action is called ([#739](#739)) ([35b8caf](35b8caf)), closes [#723](#723) [#738](#738) ### Features * **annotation:** enable marker positioning on LineAnnotation ([#737](#737)) ([ab5e413](ab5e413)), closes [#701](#701) * add custom annotation tooltip ([#727](#727)) ([435c67c](435c67c))
🎉 This PR is included in version 19.8.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
# [19.8.0](elastic/elastic-charts@v19.7.0...v19.8.0) (2020-07-06) ### Bug Fixes * set uninitialized state when removeSpec action is called ([opensearch-project#739](elastic/elastic-charts#739)) ([9c49c90](elastic/elastic-charts@9c49c90)), closes [opensearch-project#723](elastic/elastic-charts#723) [opensearch-project#738](elastic/elastic-charts#738) ### Features * **annotation:** enable marker positioning on LineAnnotation ([opensearch-project#737](elastic/elastic-charts#737)) ([2fa5a0b](elastic/elastic-charts@2fa5a0b)), closes [opensearch-project#701](elastic/elastic-charts#701) * add custom annotation tooltip ([opensearch-project#727](elastic/elastic-charts#727)) ([f03d566](elastic/elastic-charts@f03d566))
Summary
Prop to render custom annotation tooltip or tooltip details. Add tooltip portal options for more control of placement, offset and boundary.
Depreciates
renderTooltip
prop in favor ofcustomTooltipDetails
prop.Checklist
Delete any items that are not applicable to this PR.
src/index.ts
(and stories only import from../src
except for test data & storybook)