Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Annotation label] Line annotation label at top #701

Closed
shahzad31 opened this issue Jun 10, 2020 · 1 comment · Fixed by #737
Closed

[Annotation label] Line annotation label at top #701

shahzad31 opened this issue Jun 10, 2020 · 1 comment · Fixed by #737
Assignees
@markov00
Labels
:annotation Annotation (line, rect, text) related issue enhancement New feature or request released Issue released publicly

Comments

@shahzad31
Copy link
Contributor

Describe the solution you'd like
we are displaying percentiles on chart using line annotation, we need to display label on top, saying 50th , 80th or 90th. Right now we can have marker on annotation, marker position should be configurable to the top of annotation.

Describe alternatives you've considered
Using marker but it's only position is bottom axis.

Additional context
Add any other context or screenshots about the feature request here.

Kibana Cross Issues
Something like this
image

Ideally we would like to have this feature by 7.9 kibana release.
@shahzad31 shahzad31 added the enhancement New feature or request label Jun 10, 2020
@nickofthyme nickofthyme added the :annotation Annotation (line, rect, text) related issue label Jun 10, 2020
@markov00 markov00 self-assigned this Jul 1, 2020
markov00 added a commit to markov00/elastic-charts that referenced this issue Jul 3, 2020
@markov00
feat(annotation): enable marker positioning on LineAnnotation
ddec3f1 
This commit allows changing the marker position on a line annotation. The position is absolute on
the screen space and doesn't depend on the chart rotation

fix elastic#701
@markov00 markov00 mentioned this issue Jul 3, 2020
Merged
3 tasks
markov00 added a commit that referenced this issue Jul 6, 2020
@markov00
feat(annotation): enable marker positioning on LineAnnotation (#737)
ab5e413 
This commit allows changing the marker position on a line annotation. The position is absolute on
the screen space and doesn't depend on the chart rotation

fix #701
markov00 pushed a commit that referenced this issue Jul 6, 2020
@semantic-release-bot
chore(release): 19.8.0 [skip ci]
20e27cb 
# [19.8.0](v19.7.0...v19.8.0) (2020-07-06)

### Bug Fixes

* set uninitialized state when removeSpec action is called ([#739](#739)) ([35b8caf](35b8caf)), closes [#723](#723) [#738](#738)

### Features

* **annotation:** enable marker positioning on LineAnnotation ([#737](#737)) ([ab5e413](ab5e413)), closes [#701](#701)
* add custom annotation tooltip ([#727](#727)) ([435c67c](435c67c))
@markov00
Copy link
Member

markov00 commented Jul 6, 2020

🎉 This issue has been resolved in version 19.8.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@markov00 markov00 added the released Issue released publicly label Jul 6, 2020
AMoo-Miki pushed a commit to AMoo-Miki/OpenSearch-Dashboards that referenced this issue Feb 10, 2022
@semantic-release-bot
chore(release): 19.8.0 [skip ci]
75a6070 
# [19.8.0](elastic/elastic-charts@v19.7.0...v19.8.0) (2020-07-06)

### Bug Fixes

* set uninitialized state when removeSpec action is called ([opensearch-project#739](elastic/elastic-charts#739)) ([9c49c90](elastic/elastic-charts@9c49c90)), closes [opensearch-project#723](elastic/elastic-charts#723) [opensearch-project#738](elastic/elastic-charts#738)

### Features

* **annotation:** enable marker positioning on LineAnnotation ([opensearch-project#737](elastic/elastic-charts#737)) ([2fa5a0b](elastic/elastic-charts@2fa5a0b)), closes [opensearch-project#701](elastic/elastic-charts#701)
* add custom annotation tooltip ([opensearch-project#727](elastic/elastic-charts#727)) ([f03d566](elastic/elastic-charts@f03d566))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@markov00 markov00

Labels
:annotation Annotation (line, rect, text) related issue enhancement New feature or request released Issue released publicly
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(annotation): enable marker positioning on LineAnnotation markov00/elastic-charts
3 participants
@markov00 @shahzad31 @nickofthyme