Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wrong status when removing a spec from the configuration #738

Closed
markov00 opened this issue Jul 6, 2020 · 1 comment · Fixed by #739
Closed

Wrong status when removing a spec from the configuration #738

markov00 opened this issue Jul 6, 2020 · 1 comment · Fixed by #739
Assignees
@markov00
Labels
bug Something isn't working kibana cross issue Has a Kibana issue counterpart released Issue released publicly

Comments

@markov00
Copy link
Member

markov00 commented Jul 6, 2020

Describe the bug
When sending the removeSpec action due to a change in the chart configuration, the chart is in the wrong status. In particular, the state confirms that the chart isInitialized when it is clearly not.

To Reproduce
Steps to reproduce the behavior:

  1. Use the following code to reproduce: https://codesandbox.io/s/recursing-joliot-iht2v?file=/src/App.tsx
  2. Click on the text Change bar to line
  3. See error

Expected behaviour
A clear and concise description of what you expected to happen.

Version (please complete the following information):

  • Elastic Charts: 19.6.2

Additional context
Regression caused by #723

Errors in browser console

Uncaught Error: Cannot compute scale for axis spec right
    at Object.computeAxisTicksDimensions (axis_utils.js:24)
    at compute_axis_ticks_dimensions.js:31
    at Array.forEach (<anonymous>)
    at compute_axis_ticks_dimensions.js:29
    at resultFuncWithRecomputations (index.js:77)
    at index.js:70
    at index.js:30
    at index.js:84
    at index.js:30
    at selector (index.js:105)
computeAxisTicksDimensions @ axis_utils.js:24
(anonymous) @ compute_axis_ticks_dimensions.js:31
(anonymous) @ compute_axis_ticks_dimensions.js:29
resultFuncWithRecomputations @ index.js:77
(anonymous) @ index.js:70
(anonymous) @ index.js:30
(anonymous) @ index.js:84
(anonymous) @ index.js:30
selector @ index.js:105
(anonymous) @ index.js:80
(anonymous) @ index.js:30
selector @ index.js:105
(anonymous) @ index.js:80
(anonymous) @ index.js:30
selector @ index.js:105
(anonymous) @ index.js:80
(anonymous) @ index.js:30
selector @ index.js:105
(anonymous) @ index.js:80
(anonymous) @ index.js:30
selector @ index.js:105
(anonymous) @ on_element_over_caller.js:56
push.../../node_modules/@elastic/charts/dist/chart_types/xy_chart/state/chart_state.js.XYAxisChartState.eventCallbacks @ chart_state.js:85
(anonymous) @ chart.js:106
dispatch @ redux.js:221
(anonymous) @ redux.js:475
(anonymous) @ spec_factory.js:36
callCallback @ react-dom.development.js:336

Kibana Cross Issues
@markov00 markov00 added bug Something isn't working kibana cross issue Has a Kibana issue counterpart labels Jul 6, 2020
@markov00 markov00 self-assigned this Jul 6, 2020
markov00 added a commit to markov00/elastic-charts that referenced this issue Jul 6, 2020
@markov00
fix: set uninitialized state when removeSpec action is called
005cf6b 
This commit reset the chart state to not initialized when removing a spec. After elastic#723 PR that
reduced the number of steps on the state machine when parsing, the removeSpec action wasn't
accounted on that refactoring causing side effects when removing/switching a spec on the chart
configuration due to the state being in an wrong status.

fix elastic#738
@markov00 markov00 mentioned this issue Jul 6, 2020
Merged
1 task
markov00 added a commit that referenced this issue Jul 6, 2020
@markov00
fix: set uninitialized state when removeSpec action is called (#739)
35b8caf 
This commit reset the chart state to not initialized when removing a spec. After #723 PR that
reduced the number of steps on the state machine when parsing, the removeSpec action wasn't
accounted on that refactoring causing side effects when removing/switching a spec on the chart
configuration due to the state being in an wrong status.

fix #738
markov00 pushed a commit that referenced this issue Jul 6, 2020
@semantic-release-bot
chore(release): 19.8.0 [skip ci]
20e27cb 
# [19.8.0](v19.7.0...v19.8.0) (2020-07-06)

### Bug Fixes

* set uninitialized state when removeSpec action is called ([#739](#739)) ([35b8caf](35b8caf)), closes [#723](#723) [#738](#738)

### Features

* **annotation:** enable marker positioning on LineAnnotation ([#737](#737)) ([ab5e413](ab5e413)), closes [#701](#701)
* add custom annotation tooltip ([#727](#727)) ([435c67c](435c67c))
@markov00
Copy link
Member Author

markov00 commented Jul 6, 2020

🎉 This issue has been resolved in version 19.8.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@markov00 markov00 added the released Issue released publicly label Jul 6, 2020
AMoo-Miki pushed a commit to AMoo-Miki/OpenSearch-Dashboards that referenced this issue Feb 10, 2022
@semantic-release-bot
chore(release): 19.8.0 [skip ci]
75a6070 
# [19.8.0](elastic/elastic-charts@v19.7.0...v19.8.0) (2020-07-06)

### Bug Fixes

* set uninitialized state when removeSpec action is called ([opensearch-project#739](elastic/elastic-charts#739)) ([9c49c90](elastic/elastic-charts@9c49c90)), closes [opensearch-project#723](elastic/elastic-charts#723) [opensearch-project#738](elastic/elastic-charts#738)

### Features

* **annotation:** enable marker positioning on LineAnnotation ([opensearch-project#737](elastic/elastic-charts#737)) ([2fa5a0b](elastic/elastic-charts@2fa5a0b)), closes [opensearch-project#701](elastic/elastic-charts#701)
* add custom annotation tooltip ([opensearch-project#727](elastic/elastic-charts#727)) ([f03d566](elastic/elastic-charts@f03d566))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@markov00 markov00

Labels
bug Something isn't working kibana cross issue Has a Kibana issue counterpart released Issue released publicly
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: set uninitialized state when removeSpec action is called markov00/elastic-charts
1 participant
@markov00