Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add customTooltipDetails option in Partition chart #809

Closed
shahzad31 opened this issue Sep 8, 2020 · 3 comments · Fixed by #818
Closed

Add customTooltipDetails option in Partition chart #809

shahzad31 opened this issue Sep 8, 2020 · 3 comments · Fixed by #818
Labels
enhancement New feature or request :partition Partition/PieChart/Donut/Sunburst/Treemap chart related released Issue released publicly

Comments

@shahzad31
Copy link
Contributor

shahzad31 commented Sep 8, 2020

Partition chart doesn't support customTooltipDetails or deprecated renderTooltip option,

in Kibana Client Side Monitoring app we would like to customise tool tips but there is no option in partition chart

Example as

Chrome mobile:
Count 33
% of impressions 37.6%

Kibana issue elastic/kibana#76953

@shahzad31 shahzad31 added the enhancement New feature or request label Sep 8, 2020
@monfera monfera added the :partition Partition/PieChart/Donut/Sunburst/Treemap chart related label Sep 8, 2020
@nickofthyme nickofthyme added this to the Kibana 7.10 milestone Sep 8, 2020
@monfera
Copy link
Contributor

monfera commented Sep 8, 2020

Rollout of #727

@nickofthyme
Copy link
Collaborator

@shahzad31 After digging into this further we DO in fact support this functionality as of @elastic/[email protected]. It was added in #651.

The API is the same across all chart types accessed via Settings.tooltip. Something like...

<Chart>
  <Settings tooltip={{ customTooltip: () => <div>My Tooltip</div> }} />
  {/* ... */}
</Chart>

I put up a PR to add an example of this to our storybook for partition charts here #818

@markov00
Copy link
Member

🎉 This issue has been resolved in version 21.3.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@markov00 markov00 added the released Issue released publicly label Sep 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request :partition Partition/PieChart/Donut/Sunburst/Treemap chart related released Issue released publicly
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants