-
Notifications
You must be signed in to change notification settings - Fork 121
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat/banded legend values #398
Feat/banded legend values #398
Conversation
Allow user to set postfix for upper and lower bound of banded series to distinguish between values closes elastic#162
update displayValue type changes, fix defaulting point values from 0 to null.
Codecov Report
@@ Coverage Diff @@
## master #398 +/- ##
========================================
- Coverage 98.05% 98% -0.06%
========================================
Files 39 39
Lines 2833 2853 +20
Branches 673 664 -9
========================================
+ Hits 2778 2796 +18
Misses 50 50
- Partials 5 7 +2
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are some small comments to solve before merge. Tested locally and I cannot find issues on that
This reverts commit 218402c.
- Allow user to set postfix for upper and lower bound of banded series to distinguish between values sets - Update `displayValue` type changes, fix defaulting point values from 0 to null. closes elastic#162
# [13.4.0](elastic/elastic-charts@v13.3.0...v13.4.0) (2019-10-07) ### Features * banded legend values ([opensearch-project#398](elastic/elastic-charts#398) & [opensearch-project#408](elastic/elastic-charts#408)) ([ca1c7ac](elastic/elastic-charts@ca1c7ac)), closes [opensearch-project#162](elastic/elastic-charts#162)
Summary
Continuation of #391 (first commit comes from #391)
closes #163
Add duplicated values on the legend for banded AREA series. Legend will show upper and lower series values.
Update last values to find last values for
y0
andy1
Also "fixes"/removes the tooltip from showing
undefined
seriesy0
values as0
. Nowundefined
y0
values are filtered out of the tooltip. These values will show as blanks in the legend.Screenshots
Checklist
src/index.ts
(and stories only import from../src
except for test data & storybook)