Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/banded legend values #398

Merged
merged 5 commits into from
Oct 7, 2019

Conversation

nickofthyme
Copy link
Collaborator

Summary

Continuation of #391 (first commit comes from #391)

closes #163

Add duplicated values on the legend for banded AREA series. Legend will show upper and lower series values.

Update last values to find last values for y0 and y1

Also "fixes"/removes the tooltip from showing undefined series y0 values as 0. Now undefined y0 values are filtered out of the tooltip. These values will show as blanks in the legend.

Screenshots

Screen Recording 2019-09-28 at 01 42 PM

Checklist

  • Any consumer-facing exports were added to src/index.ts (and stories only import from ../src except for test data & storybook)
  • This was checked for cross-browser compatibility, including a check against IE11
  • Proper documentation or storybook story was added for features that require explanation or tutorials
  • Unit tests were updated or added to match the most common scenarios
  • Each commit follows the convention

Allow user to set postfix for upper and lower bound of banded series to distinguish between values

closes elastic#162
@nickofthyme nickofthyme added the :legend Legend related issue label Sep 28, 2019
update displayValue type changes, fix defaulting point values from 0 to null.
@nickofthyme nickofthyme marked this pull request as ready for review October 2, 2019 18:20
@codecov-io
Copy link

codecov-io commented Oct 2, 2019

Codecov Report

Merging #398 into master will decrease coverage by 0.05%.
The diff coverage is 92.1%.

Impacted file tree graph

@@           Coverage Diff            @@
##           master   #398      +/-   ##
========================================
- Coverage   98.05%    98%   -0.06%     
========================================
  Files          39     39              
  Lines        2833   2853      +20     
  Branches      673    664       -9     
========================================
+ Hits         2778   2796      +18     
  Misses         50     50              
- Partials        5      7       +2
Impacted Files Coverage Δ
src/chart_types/xy_chart/utils/specs.ts 100% <ø> (ø) ⬆️
...chart_types/xy_chart/utils/stacked_series_utils.ts 98.21% <100%> (ø) ⬆️
src/chart_types/xy_chart/store/utils.ts 96.76% <100%> (+0.05%) ⬆️
src/chart_types/xy_chart/utils/series.ts 100% <100%> (ø) ⬆️
src/chart_types/xy_chart/legend/legend.ts 95% <88.23%> (-5%) ⬇️
src/chart_types/xy_chart/tooltip/tooltip.ts 93.75% <89.47%> (+0.52%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dfd5d7b...cc7b250. Read the comment docs.

Copy link
Member

@markov00 markov00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are some small comments to solve before merge. Tested locally and I cannot find issues on that

src/chart_types/xy_chart/rendering/rendering.ts Outdated Show resolved Hide resolved
src/chart_types/xy_chart/utils/specs.ts Outdated Show resolved Hide resolved
src/chart_types/xy_chart/utils/specs.ts Outdated Show resolved Hide resolved
src/components/tooltips.tsx Outdated Show resolved Hide resolved
@nickofthyme nickofthyme merged commit 218402c into elastic:master Oct 7, 2019
nickofthyme added a commit that referenced this pull request Oct 7, 2019
nickofthyme added a commit that referenced this pull request Oct 7, 2019
@nickofthyme nickofthyme deleted the feat/banded-legend-values branch October 7, 2019 19:11
nickofthyme added a commit to nickofthyme/elastic-charts that referenced this pull request Oct 7, 2019
- Allow user to set postfix for upper and lower bound of banded series to distinguish between values sets
- Update `displayValue` type changes, fix defaulting point values from 0 to null.

closes elastic#162
@nickofthyme nickofthyme mentioned this pull request Oct 7, 2019
5 tasks
nickofthyme added a commit that referenced this pull request Oct 7, 2019
- Allow user to set postfix for upper and lower bound of banded series to distinguish between values sets
- Update `displayValue` type changes, fix defaulting point values from 0 to null.

closes #162
markov00 pushed a commit that referenced this pull request Oct 7, 2019
# [13.4.0](v13.3.0...v13.4.0) (2019-10-07)

### Features

* banded legend values ([#398](#398) & [#408](#408)) ([5c35a4d](5c35a4d)), closes [#162](#162)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:legend Legend related issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Display y0 and y1 values on legend for band charts
3 participants