[Rename] kibana-usage-collection plugin #162
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Kawika Avilla <[email protected]>
boktorbb
suggested changes
Mar 11, 2021
| @@ -55,7 +55,7 @@ export const applicationUsageSchema = { | |||
| dev_tools: commonSchema, | |||
| discover: commonSchema, | |||
| home: commonSchema, | |||
| kibana: commonSchema, // It's a forward app so we'll likely never report it | |||
| opensearch_dashboards: commonSchema, // It's a forward app so we'll likely never report it | |||
There was a problem hiding this comment.
why is this using '_' it looks like it's referring to the module so it should be opensearch-dashboards
There was a problem hiding this comment.
I think trying to follow what other in below following.
kavilla
referenced
this pull request
in kavilla/OpenSearch-Dashboards
Mar 19, 2021
Signed-off-by: Kawika Avilla <[email protected]>
kavilla
added a commit
that referenced
this pull request
Mar 20, 2021
Signed-off-by: Kawika Avilla <[email protected]>
mihirsoni
pushed a commit
that referenced
this pull request
Mar 20, 2021
Signed-off-by: Kawika Avilla <[email protected]>
raintygao
pushed a commit
to raintygao/OpenSearch-Dashboards
that referenced
this pull request
Sep 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
#37
Description of changes:
Rename folder, files, variables within plugins/kibana-usage-collection
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.