Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Display y0 and y1 names on tooltip for band charts #162

Closed
markov00 opened this issue Apr 10, 2019 · 7 comments · Fixed by #391 or #408
Closed

Display y0 and y1 names on tooltip for band charts #162

markov00 opened this issue Apr 10, 2019 · 7 comments · Fixed by #391 or #408
Assignees
@nickofthyme
Labels
enhancement New feature or request released Issue released publicly

Comments

@markov00
Copy link
Member

A band area chart tooltip does't display two different names for the y0 and y1 value.
The same happens for a bar chart with y0 accessors, it will display only the y1 value.
@markov00 markov00 added the enhancement New feature or request label Apr 10, 2019
@markov00 markov00 mentioned this issue Apr 10, 2019
Merged
5 tasks
@Kerry350 Kerry350 mentioned this issue Aug 16, 2019
Merged
5 tasks
@simianhacker simianhacker mentioned this issue Sep 16, 2019
Closed
@nickofthyme nickofthyme self-assigned this Sep 23, 2019
@nickofthyme
Copy link
Collaborator

Related to #163

nickofthyme added a commit to nickofthyme/elastic-charts that referenced this issue Sep 24, 2019
@nickofthyme
feat(tooltip): allow postfix banded area series
3f1c918 
Allow user to set postfix for upper and lower bound of banded series to distinguish between values

closes elastic#162
@nickofthyme nickofthyme mentioned this issue Sep 24, 2019
Merged
5 tasks
@nickofthyme
Copy link
Collaborator

nickofthyme commented Sep 24, 2019 •
edited
Loading

@cchaos Could you comment on how this should be styled? It's basically when we have a banded area or bar series and how to display the lower and upper bounds in the tooltip and legend (#163).

The way it is setup now the tooltip would have two labels and two values like this and the label would distinguish them.

Screen Shot 2019-09-24 at 1 16 04 PM

But I am thinking it would be better if we kept them as one series and stacked the values in some way. This would be better for the legend too because I want to avoid having two legend values, mainly to avoid hiding and showing of the upper and lower bounds which doesn't really make sense. Also the dual label is a little redundant.

I'm thinking of something like below.

Screen Shot 2019-09-24 at 1 17 51 PM

Screen Shot 2019-09-24 at 1 19 41 PM

If you could also comment on how the legend should look on #163, that would be greatly appreciated.

@cchaos
Copy link
Contributor

cchaos commented Sep 24, 2019

Visually I would love to see the values in the tooltip be represented in the similar order to the one on the graph.

area - upper          17.22
average                9.92
area - lower           3.12

@nickofthyme
Copy link
Collaborator

nickofthyme commented Sep 24, 2019 •
edited
Loading

Ooo that will be a little difficult since area and average are completely separate series.

If we were able to do it this way that would create 2 legend entries, which I think there should only be one so we don't allow toggling the upper and lower bounds separately.

What would be your second option, if this is not possible?

@cchaos
Copy link
Contributor

cchaos commented Sep 25, 2019

Then I'd just write it out as upper and lower.

nickofthyme added a commit that referenced this issue Oct 2, 2019
@nickofthyme
feat(tooltip): tooltip label format for upper/lower banded area series (
dfd5d7b 
#391)

Allow users to set a formatted label for upper and lower bound of banded series to distinguish between series in tooltip. Format allows a postfix string or accessor function.

closes #162
markov00 pushed a commit that referenced this issue Oct 2, 2019
@semantic-release-bot
chore(release): 13.3.0 [skip ci]
1c8625f 
# [13.3.0](v13.2.0...v13.3.0) (2019-10-02)

### Features

* **tooltip:** tooltip label format for upper/lower banded area series ([#391](#391)) ([dfd5d7b](dfd5d7b)), closes [#162](#162)
@markov00
Copy link
Member Author

markov00 commented Oct 2, 2019

🎉 This issue has been resolved in version 13.3.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@markov00 markov00 added the released Issue released publicly label Oct 2, 2019
nickofthyme added a commit that referenced this issue Oct 7, 2019
@nickofthyme
Feat/banded legend values (#398)
218402c 
- Allow user to set postfix for upper and lower bound of banded series to distinguish between values sets
- Update `displayValue` type changes, fix defaulting point values from 0 to null.

closes #162
nickofthyme added a commit to nickofthyme/elastic-charts that referenced this issue Oct 7, 2019
@nickofthyme
Feat/banded legend values (elastic#398)
e37ae4c 
- Allow user to set postfix for upper and lower bound of banded series to distinguish between values sets
- Update `displayValue` type changes, fix defaulting point values from 0 to null.

closes elastic#162
@nickofthyme nickofthyme mentioned this issue Oct 7, 2019
Merged
5 tasks
nickofthyme added a commit that referenced this issue Oct 7, 2019
@nickofthyme
feat: banded legend values (#398 & #408)
5c35a4d 
- Allow user to set postfix for upper and lower bound of banded series to distinguish between values sets
- Update `displayValue` type changes, fix defaulting point values from 0 to null.

closes #162
markov00 pushed a commit that referenced this issue Oct 7, 2019
@semantic-release-bot
chore(release): 13.4.0 [skip ci]
af1e2fc 
# [13.4.0](v13.3.0...v13.4.0) (2019-10-07)

### Features

* banded legend values ([#398](#398) & [#408](#408)) ([5c35a4d](5c35a4d)), closes [#162](#162)
@markov00
Copy link
Member Author

markov00 commented Oct 7, 2019

🎉 This issue has been resolved in version 13.4.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

AMoo-Miki pushed a commit to AMoo-Miki/OpenSearch-Dashboards that referenced this issue Feb 10, 2022
@semantic-release-bot
chore(release): 13.3.0 [skip ci]
17f03c7 
# [13.3.0](elastic/elastic-charts@v13.2.0...v13.3.0) (2019-10-02)

### Features

* **tooltip:** tooltip label format for upper/lower banded area series ([opensearch-project#391](elastic/elastic-charts#391)) ([701264c](elastic/elastic-charts@701264c)), closes [opensearch-project#162](elastic/elastic-charts#162)
AMoo-Miki pushed a commit to AMoo-Miki/OpenSearch-Dashboards that referenced this issue Feb 10, 2022
@semantic-release-bot
chore(release): 13.4.0 [skip ci]
c47f0e6 
# [13.4.0](elastic/elastic-charts@v13.3.0...v13.4.0) (2019-10-07)

### Features

* banded legend values ([opensearch-project#398](elastic/elastic-charts#398) & [opensearch-project#408](elastic/elastic-charts#408)) ([ca1c7ac](elastic/elastic-charts@ca1c7ac)), closes [opensearch-project#162](elastic/elastic-charts#162)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nickofthyme nickofthyme

Labels
enhancement New feature or request released Issue released publicly
Projects
None yet
Milestone
No milestone
3 participants
@cchaos @markov00 @nickofthyme