Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Feat/banded legend values" #406

Merged
merged 1 commit into from
Oct 7, 2019

Conversation

nickofthyme
Copy link
Collaborator

Reverts #398

Bad naming

@nickofthyme nickofthyme requested a review from markov00 October 7, 2019 17:18
@codecov-io
Copy link

codecov-io commented Oct 7, 2019

Codecov Report

Merging #406 into master will increase coverage by 0.05%.
The diff coverage is 92.85%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #406      +/-   ##
==========================================
+ Coverage      98%   98.05%   +0.05%     
==========================================
  Files          39       39              
  Lines        2853     2833      -20     
  Branches      681      673       -8     
==========================================
- Hits         2796     2778      -18     
  Misses         50       50              
+ Partials        7        5       -2
Impacted Files Coverage Δ
src/chart_types/xy_chart/utils/specs.ts 100% <ø> (ø) ⬆️
...chart_types/xy_chart/utils/stacked_series_utils.ts 98.21% <100%> (ø) ⬆️
src/chart_types/xy_chart/store/utils.ts 96.7% <100%> (-0.06%) ⬇️
src/chart_types/xy_chart/legend/legend.ts 100% <100%> (+5%) ⬆️
src/chart_types/xy_chart/utils/series.ts 100% <100%> (ø) ⬆️
src/chart_types/xy_chart/tooltip/tooltip.ts 93.22% <87.87%> (-0.53%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 218402c...09bd813. Read the comment docs.

@nickofthyme nickofthyme merged commit 8e23708 into master Oct 7, 2019
@nickofthyme nickofthyme deleted the revert-398-feat/banded-legend-values branch February 21, 2020 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants