Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Meta] Create API reference templates #937

Closed
4 tasks done
KOTungseth opened this issue Jun 19, 2019 · 7 comments
Closed
4 tasks done

[Meta] Create API reference templates #937

KOTungseth opened this issue Jun 19, 2019 · 7 comments
Assignees

Comments

@KOTungseth
Copy link
Contributor

KOTungseth commented Jun 19, 2019

In the future, all APIs deserve reference material. For customers to effectively use the APIs, they need reference material.

  • Choose a place for a API reference template to exist, ideally a public location (Docs repo, shared folder)

  • Choose best practices from existing or other content

Good API reference page has:
* Title
* Short description/Intro
* Endpoint/Request
* Description (more detailed)
* Endpoint/Request
* Path parameters
* Query parameters
* Request body
* Response body

Some APIs also require:
* Authorization/security details
* Definition lists
* Examples
* Default values

  • Draft template for API page
    * Something that is useful, helpful to customers
    * Can be generated using tools that we have
    * Not too much glitter

  • Draft template for definition page

Tests:

@KOTungseth KOTungseth changed the title [Meta] Create an API reference template [Meta] Create API reference templates Jun 19, 2019
jrodewig added a commit that referenced this issue Jun 20, 2019
* Changes font size of <code> in a <term> to 16px. This ensures <code>
  text matches the size of other text in the <term>.

* Removes the blue text color from <term>s in a definition list. Users
  sometimes mistake this formatting as a link. This bolds <term>s
  instead.

Relates to #937.
@lcawl
Copy link
Contributor

lcawl commented Jul 9, 2019

The formatting of the parameters in the API is still a little problematic. In particular, the "Required/Optional" is unnecessarily eye-catching in my opinion. For example:
image
I did a quick test of some of the other options we discussed. For example:
image

@jrodewig
Copy link
Contributor

Here's my order of preference:

  1. allow_no_match
  2. size
  3. from

I believe the from example introduces visual clutter with the bulleted list. It will also have more overhead for Asciidoc maintenance.

The size example is okay, but I find the construction a little awkward. It's also not very clear to non-writers that they should always include "Optional" or "Required" as the first word of the definition.

I don't feel strongly though. Any of these options are fine with me.

@jrodewig
Copy link
Contributor

Going to go ahead and close this.

I feel that we've gotten good feedback and incorporated the template into most ongoing work.

Feel free to re-open if wanted.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants