Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reformats reindex API #47483

Merged
merged 2 commits into from
Oct 5, 2019
Merged

Reformats reindex API #47483

merged 2 commits into from
Oct 5, 2019

Conversation

debadair
Copy link
Contributor

@debadair debadair commented Oct 3, 2019

This PR updates the reindex API to align with the new API reference template.

The subheadings are not totally consistent--I opted to avoid changing ones that are widely linked to.

Relates to elastic/docs#937 and #45365

@debadair debadair added :Distributed Indexing/CRUD A catch all label for issues around indexing, updating and getting a doc by id. Not search. :Docs v8.0.0 v7.5.0 v7.4.1 v7.3.3 labels Oct 3, 2019
@debadair debadair requested a review from jrodewig October 3, 2019 00:45
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-distributed (:Distributed/CRUD)

@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-docs (:Docs)

Copy link
Contributor

@jrodewig jrodewig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a few comments. The only blocking change is that we need to add a request body section.

@debadair
Copy link
Contributor Author

debadair commented Oct 5, 2019

I added the request body section and moved most of the examples.

@debadair
Copy link
Contributor Author

debadair commented Oct 5, 2019

@elasticmachine, run elasticsearch-ci/docs

@debadair
Copy link
Contributor Author

debadair commented Oct 5, 2019

@elasticmachine, run elasticsearch-ci/oss-distro-docs

@debadair debadair merged commit 6710279 into elastic:master Oct 5, 2019
debadair added a commit to debadair/elasticsearch that referenced this pull request Oct 7, 2019
* Reformats reindex API

* Incorporated review feedback.
debadair added a commit that referenced this pull request Oct 7, 2019
* [DOCS] Reformats bulk API. (#47479)

* Reformats bulk API.

* Update docs/reference/docs/bulk.asciidoc

Co-Authored-By: James Rodewig <[email protected]>

* Reformats mget API (#47477)

* Reformats mget API

* Update docs/reference/docs/get.asciidoc

Co-Authored-By: James Rodewig <[email protected]>

* Incorporated feedback.

* Reformats reindex API (#47483)

* Reformats reindex API

* Incorporated review feedback.

* Reformats term vectors APIs (#47484)

* Reformat termvectors APIs

* Reformats mtermvectors

* Apply suggestions from code review

Co-Authored-By: James Rodewig <[email protected]>

* Incorporated review feedback.
debadair added a commit to debadair/elasticsearch that referenced this pull request Oct 7, 2019
)

* [DOCS] Reformats bulk API. (elastic#47479)

* Reformats bulk API.

* Update docs/reference/docs/bulk.asciidoc

Co-Authored-By: James Rodewig <[email protected]>

* Reformats mget API (elastic#47477)

* Reformats mget API

* Update docs/reference/docs/get.asciidoc

Co-Authored-By: James Rodewig <[email protected]>

* Incorporated feedback.

* Reformats reindex API (elastic#47483)

* Reformats reindex API

* Incorporated review feedback.

* Reformats term vectors APIs (elastic#47484)

* Reformat termvectors APIs

* Reformats mtermvectors

* Apply suggestions from code review

Co-Authored-By: James Rodewig <[email protected]>

* Incorporated review feedback.
debadair added a commit to debadair/elasticsearch that referenced this pull request Oct 7, 2019
)

* [DOCS] Reformats bulk API. (elastic#47479)

* Reformats bulk API.

* Update docs/reference/docs/bulk.asciidoc

Co-Authored-By: James Rodewig <[email protected]>

* Reformats mget API (elastic#47477)

* Reformats mget API

* Update docs/reference/docs/get.asciidoc

Co-Authored-By: James Rodewig <[email protected]>

* Incorporated feedback.

* Reformats reindex API (elastic#47483)

* Reformats reindex API

* Incorporated review feedback.

* Reformats term vectors APIs (elastic#47484)

* Reformat termvectors APIs

* Reformats mtermvectors

* Apply suggestions from code review

Co-Authored-By: James Rodewig <[email protected]>

* Incorporated review feedback.
debadair added a commit that referenced this pull request Oct 7, 2019
…47684)

* [DOCS] Backporting API ref reformatting for document APIs (#47631)

* [DOCS] Reformats bulk API. (#47479)

* Reformats bulk API.

* Update docs/reference/docs/bulk.asciidoc

Co-Authored-By: James Rodewig <[email protected]>

* Reformats mget API (#47477)

* Reformats mget API

* Update docs/reference/docs/get.asciidoc

Co-Authored-By: James Rodewig <[email protected]>

* Incorporated feedback.

* Reformats reindex API (#47483)

* Reformats reindex API

* Incorporated review feedback.

* Reformats term vectors APIs (#47484)

* Reformat termvectors APIs

* Reformats mtermvectors

* Apply suggestions from code review

Co-Authored-By: James Rodewig <[email protected]>

* Incorporated review feedback.

* Fixed console snippets.
debadair added a commit that referenced this pull request Oct 7, 2019
…47685)

* [DOCS] Backporting API ref reformatting for document APIs (#47631)

* [DOCS] Reformats bulk API. (#47479)

* Reformats bulk API.

* Update docs/reference/docs/bulk.asciidoc

Co-Authored-By: James Rodewig <[email protected]>

* Reformats mget API (#47477)

* Reformats mget API

* Update docs/reference/docs/get.asciidoc

Co-Authored-By: James Rodewig <[email protected]>

* Incorporated feedback.

* Reformats reindex API (#47483)

* Reformats reindex API

* Incorporated review feedback.

* Reformats term vectors APIs (#47484)

* Reformat termvectors APIs

* Reformats mtermvectors

* Apply suggestions from code review

Co-Authored-By: James Rodewig <[email protected]>

* Incorporated review feedback.

* Fixed console snippets.

* Fixed response test syntax.
@tomcallahan tomcallahan added >docs General docs changes and removed :Docs labels Oct 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:Distributed Indexing/CRUD A catch all label for issues around indexing, updating and getting a doc by id. Not search. >docs General docs changes v7.3.3 v7.4.1 v7.5.0 v8.0.0-alpha1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants