-
Notifications
You must be signed in to change notification settings - Fork 25k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DOCS] Reformats validate API #46389
Conversation
Pinging @elastic/es-docs |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left a few comments that should fix the CI. Thanks!
Co-Authored-By: James Rodewig <[email protected]>
Co-Authored-By: James Rodewig <[email protected]>
Co-Authored-By: James Rodewig <[email protected]>
@elasticmachine test this please |
@@ -202,7 +263,8 @@ GET twitter/_validate/query?rewrite=true&all_shards=true | |||
} | |||
-------------------------------------------------- | |||
|
|||
Response: | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The prior snippet needs // TEST[continued]
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jrodewig Thank you so much, it solved the problem! Please approve when you have time.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
* [DOCS] Reformats validate API. Co-Authored-By: James Rodewig <[email protected]>
* [DOCS] Reformats validate API. Co-Authored-By: James Rodewig <[email protected]>
* [DOCS] Reformats validate API. Co-Authored-By: James Rodewig <[email protected]>
Backported to 7.x, 7.4, and 7.3. |
Relates to elastic/docs#937 and #45621.
This PR updates the validate API to align with the new API reference template.
Depends on: #46377 (it adds
query
to the common params list.)Resources: