-
Notifications
You must be signed in to change notification settings - Fork 24.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DOCS] Change 'X-Pack APIs' section to 'REST APIs' #43451
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jrodewig
added
>docs
General docs changes
:Core/Infra/Plugins
Plugin API and infrastructure
:Core/Infra/REST API
REST infrastructure and utilities
v8.0.0
labels
Jun 20, 2019
Pinging @elastic/es-docs |
Pinging @elastic/es-core-infra |
jrodewig
added
:Docs
and removed
:Core/Infra/Plugins
Plugin API and infrastructure
:Core/Infra/REST API
REST infrastructure and utilities
labels
Jun 20, 2019
I will do a full rebuild to ensure this URL change doesn't cause any broken links. If it does, we can just add a deleted page, so that's no big deal. |
lcawl
approved these changes
Jun 20, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM and builds successfully
jrodewig
changed the title
[DOCS] Change 'X-Pack APIs' section to 'RESTful APIs'
[DOCS] Change 'X-Pack APIs' section to 'REST APIs'
Jun 21, 2019
@elasticmachine run elasticsearch-ci/1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Creates a new general purpose 'REST APIs' section. The goal is to eventually separate and relocate all API reference documentation to this section.
Changes
Changes the title, anchor, and description of the X-Pack APIs page to reflect a general REST APIs section.
Relocates the REST APIs section to lower in the navigation.
@lcawl I removed the
[role="xpack"]
macro as part of this. Let me know if that's alright with you. I believe including that at the API level should be okay.Before
Nav - Before
REST API Overview - Before
After
Nav - After
REST API Overview - After
Related Issues
Relates to elastic/docs#937.