[8.15](backport #40324) use go-sysinfo v1.14.1 and elastic-agent-system-metrics v0.10.6

[mergify]

Proposed commit message

use go-sysinfo v1.14.1 and elastic-agent-system-metrics v0.10.6

go-sysinfo was lower-casing FQDN by default, this new version does not. Not its user should do it if necessary. elastic-agent-system-metrics is also upgraded to a version that lowercase the FQDN when it's used as host.name

Checklist

• My code follows the style guidelines of this project
• [ ] I have commented my code, particularly in hard-to-understand areas
• [ ] I have made corresponding changes to the documentation
• [ ] I have made corresponding change to the default configuration files
• [ ] I have added tests that prove my fix is effective or that my feature works
• [ ] I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Disruptive User Impact

It might cause the FQDN or anything using it to be reported with mixed case instead of lower case

How to test this PR locally

The same idea as described on #39993
Ingest data, ensure the host metadata is added and check them on kibana

• Closes Regression: host.hostname is being lowercased #39993

Screenshots

---

This is an automatic backport of pull request #40324 done by Mergify.

Related issues

• WIP: use go-sysinfo with configurable lower-cased hostname/FQDN elastic-agent-system-metrics#177
• Allow to choose hostname and FQDN to be lowercased or not go-sysinfo#236
• [8.15](backport #40324) use go-sysinfo v1.14.1 and elastic-agent-system-metrics v0.10.6 #40523
• Backport update to elastic-agent-go-sysinfo #40507

[mergify]

Cherry-pick of a4568f9 has failed:

On branch mergify/bp/8.15/pr-40324
Your branch is up to date with 'origin/8.15'.

You are currently cherry-picking commit a4568f918c.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Changes to be committed:
	modified:   CHANGELOG.next.asciidoc
	modified:   NOTICE.txt
	modified:   libbeat/cmd/instance/beat.go

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   go.mod
	both modified:   go.sum

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

[elasticmachine]

Pinging @elastic/elastic-agent-data-plane (Team:Elastic-Agent-Data-Plane)

[mergify]

This pull request is now in conflicts. Could you fix it? 🙏
To fixup this pull request, you can check out it locally. See documentation: https://help.github.com/articles/checking-out-pull-requests-locally/

git fetch upstream
git checkout -b mergify/bp/8.15/pr-40324 upstream/mergify/bp/8.15/pr-40324
git merge upstream/8.15
git push upstream mergify/bp/8.15/pr-40324

[cmacknz]

This is a sort of maybe breaking change even though it makes us ECS compliant. Putting it in a patch release might surprise some people.

@pierrehilbert is there a reason we can't just let this go out in 8.16 instead?

[fearful-symmetry]

@cmacknz the justification here is that #40507 needs the update to elastic-agent-system metrics, but elastic-agent-system-metrics contains a breaking change that's fixed by this PR. I figured it would be better to just backport this PR than re-implement that portion that allows us to update elastic-agent-system metrics, but if you disagree I can just copy-and-paste the handful of lines in beats.go into #40507

[cmacknz]

Yeah we frequently have to backport system metrics updates to get updates that mitigate CVEs so coupling breaking changes into them is a pain.

It looks like the original PR would have made 8.15.0 if we had backported at the same time it merged to main and we just missed it. I don't think we should put potential breaking changes in patch releases.

Let's add a flag to opt in to the lowercasing, and set it to false in 8.15 and true on main. That gets around this problem (alternative solutions with the same result also work for me).

[cmacknz]

Requesting changes since I don't think we want approved breaking changes in patch releases.

[mergify]

This pull request has not been merged yet. Could you please review and merge it @AndersonQ? 🙏

[mergify]

This pull request is now in conflicts. Could you fix it? 🙏
To fixup this pull request, you can check out it locally. See documentation: https://help.github.com/articles/checking-out-pull-requests-locally/

git fetch upstream
git checkout -b mergify/bp/8.15/pr-40324 upstream/mergify/bp/8.15/pr-40324
git merge upstream/8.15
git push upstream mergify/bp/8.15/pr-40324

[AndersonQ]

Yeah we frequently have to backport system metrics updates to get updates that mitigate CVEs so coupling breaking changes into them is a pain.

It looks like the original PR would have made 8.15.0 if we had backported at the same time it merged to main and we just missed it. I don't think we should put potential breaking changes in patch releases.

Let's add a flag to opt in to the lowercasing, and set it to false in 8.15 and true on main. That gets around this problem (alternative solutions with the same result also work for me).

not the most elegant solution, but it fixes the problem with minimal changes and impact:

• Allow to choose hostname and FQDN to be lowercased or not go-sysinfo#236

[mergify]

This pull request has not been merged yet. Could you please review and merge it @AndersonQ? 🙏

[mergify]

This pull request is now in conflicts. Could you fix it? 🙏
To fixup this pull request, you can check out it locally. See documentation: https://help.github.com/articles/checking-out-pull-requests-locally/

git fetch upstream
git checkout -b mergify/bp/8.15/pr-40324 upstream/mergify/bp/8.15/pr-40324
git merge upstream/8.15
git push upstream mergify/bp/8.15/pr-40324

[AndersonQ]

closing it as elastic/go-sysinfo#236 was closed