use go-sysinfo v1.14.1 and elastic-agent-system-metrics v0.10.6 #40324
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
botelastic
bot
added
the
needs_team
|
This pull request does not have a backport label.
To fixup this pull request, you need to add the backport labels for the needed
|
AndersonQ
added
bug
Team:Elastic-Agent-Data-Plane
botelastic
bot
removed
the
needs_team
|
Pinging @elastic/elastic-agent-data-plane (Team:Elastic-Agent-Data-Plane) |
|
@AndersonQ I think the test cases are failing because the non-fatal PR is yet to be merged. #40298, it requires one more review from code owner and we should be good to go. |
jlind23
approved these changes
Jul 26, 2024
|
Removed by review, thought it was just a version bump but saw a change in beat.go file. |
go-sysinfo was lower-casing FQDN by default, this new version does not. Not its user should do it if necessary. elastic-agent-system-metrics is also upgraded to a version that lowercase the FQDN when it's used as `host.name`
AndersonQ
force-pushed
the
39993-fqdn-as-is
branch
from
c7b941d to
9a62d84
Compare
6 tasks
AndersonQ
added
the
backport-8.15
mergify bot
pushed a commit
that referenced
this pull request
Aug 14, 2024
* use go-sysinfo v1.14.1 and elastic-agent-system-metrics v0.10.6 go-sysinfo was lower-casing FQDN by default, this new version does not. Not its user should do it if necessary. elastic-agent-system-metrics is also upgraded to a version that lowercase the FQDN when it's used as `host.name` (cherry picked from commit a4568f9) # Conflicts: # go.mod # go.sum
Closed
1 task
AndersonQ
added a commit
that referenced
this pull request
Aug 23, 2024
* use go-sysinfo v1.14.1 and elastic-agent-system-metrics v0.10.6 go-sysinfo was lower-casing FQDN by default, this new version does not. Not its user should do it if necessary. elastic-agent-system-metrics is also upgraded to a version that lowercase the FQDN when it's used as `host.name` (cherry picked from commit a4568f9) # Conflicts: # go.mod # go.sum
|
For anyone looking at this PR: it was not backported and it will be in 8.16.x as the change might constitute a breaking change in terms of host names |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed commit message
use go-sysinfo v1.14.1 and elastic-agent-system-metrics v0.10.6
go-sysinfo was lower-casing FQDN by default, this new version does not. Not its user should do it if necessary. elastic-agent-system-metrics is also upgraded to a version that lowercase the FQDN when it's used as
host.nameChecklist
[ ] I have commented my code, particularly in hard-to-understand areas[ ] I have made corresponding changes to the documentation[ ] I have made corresponding change to the default configuration files[ ] I have added tests that prove my fix is effective or that my feature works[ ] I have added an entry inCHANGELOG.next.asciidocorCHANGELOG-developer.next.asciidoc.Disruptive User Impact
It might cause the FQDN or anything using it to be reported with mixed case instead of lower case
How to test this PR locally
The same idea as described on #39993
Ingest data, ensure the host metadata is added and check them on kibana
host.hostnameis being lowercased #39993Screenshots