Backport update to elastic-agent-go-sysinfo

[fearful-symmetry]

Proposed commit message

See #40491

Updates elastic-agent-system-metrics to v0.11.1 to remove an erroneous log line.

go get was insistent on updating go-sysinfo as well.

[cmacknz]

Looks like the merge ate the changelog.

[andrewkroh]

In effect, this is also backporting #40324 b/c of the sysinfo version. Just checking this is desired in a patch?

[fearful-symmetry]

hmm, good point. @AndersonQ is that safe to backport?

[fearful-symmetry]

Sigh. So elastic/elastic-agent-system-metrics#163 introduced a breaking change which was fixed in main by #40324, so if we don't want to backport that PR, we'll need to manually make some of the changes here.

[AndersonQ]

hmm, good point. @AndersonQ is that safe to backport?

yes, it does have a breaking change, but it's reverting a breaking change.

[AndersonQ]

Sigh. So elastic/elastic-agent-system-metrics#163 introduced a breaking change which was fixed in main by #40324, so if we don't want to backport that PR, we'll need to manually make some of the changes here.

I don't see a problem backporting them. Are you sure you linked the right system-metrics PR?

[AndersonQ]

We could backport #40324 or just add the changelog form it to this backport

[fearful-symmetry]

@AndersonQ can you backport that PR, if it's not too much trouble?

[AndersonQ]

of course

[AndersonQ]

here is the backport:

• [8.15](backport #40324) use go-sysinfo v1.14.1 and elastic-agent-system-metrics v0.10.6 #40523

[elasticmachine]

Pinging @elastic/elastic-agent-data-plane (Team:Elastic-Agent-Data-Plane)

[fearful-symmetry]

@cmacknz so, this is a mess. In addition to the changes we discussed previously, there's also elastic/elastic-agent-system-metrics#172, which also introduced a ton of breaking changes, and I don't think we'd want to backport all of that to 8.15 as well.

I think we should just make a new branch in elastic-agent-system metrics that's around the tag of v0.10.3, backport the logging fix to that branch, and point the 8.15 branch of beats at that, or perhaps some other branch/release related fix, for the sake of getting this fix out before the freeze for 8.15.1. We should also probably just tag the main of elastic-agent-system-metrics as v1.0, so we force ourselves to have some kind of API guarantees, so this doesn't happen again.

[AndersonQ]

We should also probably just tag the main of elastic-agent-system-metrics as v1.0, so we force ourselves to have some kind of API guarantees, so this doesn't happen again.

Agreed. I confess I think we should keep a v0 unless it's under active development and we do not know it's final form yet.

@fearful-symmetry I opened a PR to allow to set the hostname/fqdn to be lowercase. I'm using globals, well, because it allows to change the behaviour without changing the API, a quick fix to this mess:

• Allow to choose hostname and FQDN to be lowercased or not go-sysinfo#236

[mergify]

This pull request is now in conflicts. Could you fix it? 🙏
To fixup this pull request, you can check out it locally. See documentation: https://help.github.com/articles/checking-out-pull-requests-locally/

git fetch upstream
git checkout -b system-metrics-upgrade-11.1-backport upstream/system-metrics-upgrade-11.1-backport
git merge upstream/8.15
git push upstream system-metrics-upgrade-11.1-backport