Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update elastic-agent-system-metrics to point to our special backport for 8.15 #40620

Conversation

fearful-symmetry
Copy link
Contributor

@fearful-symmetry fearful-symmetry commented Aug 26, 2024

Proposed commit message

See #40507 for a bit more context.

We need to update elastic-agent-system-metrics to fix a logging bug: elastic/elastic-agent-system-metrics@9db0a02

However, the elastic-agent-system metrics repo has gone through so many breaking changes that we can't just cut a new release from main and update the dependency in 8.15. Instead, this updates the dependency to point at a special branch of elastic_agent_system_metrics: https://github.com/elastic/elastic-agent-system-metrics/tree/backport_8.15
If anyone can think of a less horrible way to do this, please tell me.

Checklist

  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

@fearful-symmetry fearful-symmetry requested a review from a team as a code owner August 26, 2024 16:57
@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Aug 26, 2024
@fearful-symmetry fearful-symmetry added the Team:Security-Linux Platform Linux Platform Team in Security Solution label Aug 26, 2024
@elasticmachine
Copy link
Collaborator

Pinging @elastic/sec-linux-platform (Team:Security-Linux Platform)

@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Aug 26, 2024
Copy link
Contributor

@blakerouse blakerouse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That is a lot of commits between main and what 8.15 is using. I can't think of a better way to handle this, then what you did either.

Copy link
Collaborator

@pierrehilbert pierrehilbert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving basing myself on Blake's review

@fearful-symmetry fearful-symmetry merged commit cf9566f into elastic:8.15 Aug 27, 2024
123 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Team:Security-Linux Platform Linux Platform Team in Security Solution
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants