Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regression: host.hostname is being lowercased #39993

Closed
ycombinator opened this issue Jun 22, 2024 · 2 comments · Fixed by #40324
Closed

Regression: host.hostname is being lowercased #39993

ycombinator opened this issue Jun 22, 2024 · 2 comments · Fixed by #40324
Assignees
Labels
bug Team:Elastic-Agent-Data-Plane Label for the Agent Data Plane team

Comments

@ycombinator
Copy link
Contributor

ycombinator commented Jun 22, 2024

Version

8.15.0-SNAPSHOT, 8.13.2, likely any version >= 8.9.0.

Operating System

Windows 10, but quite likely this is happening on any Windows versions, and likely on any OS that allows setting a hostname with uppercase characters in it.

Steps to Reproduce

  1. Ensure that the host on which Agent is going to run has a hostname with uppercase characters in it, e.g. DESKTOP-E39GQOG.
  2. Enroll Elastic Agent in Fleet, using the default policy with the system integration enabled.
  3. About 30 seconds after enrolling, go to Kibana > Discover and look at the logs-* indices for data from the Agent. Set up the columns as shown in the screenshot below.
    8 15 0-SNAPSHOT
  4. Note the values in the host.hostname column.

Expected behavior

The values of the host.hostname field should be exactly the same as of the hostname from step 1 above, including matching the case exactly.

Observed behavior

The values of the host.hostname field are lowercased.

Other relevant information

This behavior is not observed in 8.8.2:
8 8 2

⚠️ When fixing this regression, only the value of the host.hostname field should be fixed. The value of host.name should remain lowercased, as mandated by ECS. Similarly, the value of agent.name should not be impacted by the fix either.

@ycombinator ycombinator added bug Team:Elastic-Agent-Data-Plane Label for the Agent Data Plane team labels Jun 22, 2024
@elasticmachine
Copy link
Collaborator

Pinging @elastic/elastic-agent-data-plane (Team:Elastic-Agent-Data-Plane)

@efd6
Copy link
Contributor

efd6 commented Jun 25, 2024

It looks to me like this happens because of elastic/go-sysinfo#180. This was picked up in e35a094 which is in the 8.9 branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Team:Elastic-Agent-Data-Plane Label for the Agent Data Plane team
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants