Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Elastic Agent] Add event.dataset to all events #20076

Merged
merged 3 commits into from
Jul 22, 2020
Merged

[Elastic Agent] Add event.dataset to all events #20076

merged 3 commits into from
Jul 22, 2020

Conversation

blakerouse
Copy link
Contributor

@blakerouse blakerouse commented Jul 20, 2020 •
edited
Loading

What does this PR do?

Adds event.dataset to match the same as dataset.name from the event. This is done on all configurations, even the sidecar monitoring beats.

Why is it important?

So published events do not prevent other features from working in Kibana and ML.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • [ ] I have made corresponding changes to the documentation
  • [ ] I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

How to test this PR locally

Run elastic-agent ensure that all events published to elasticsearch have event.dataset that matches the dataset.name.

Related issues

@blakerouse blakerouse self-assigned this Jul 20, 2020
@botelastic botelastic bot added needs_team Indicates that the issue/PR needs a Team:* label and removed needs_team Indicates that the issue/PR needs a Team:* label labels Jul 20, 2020
@blakerouse blakerouse marked this pull request as ready for review July 20, 2020 19:56
@elasticmachine
Copy link
Collaborator

Pinging @elastic/ingest-management (Team:Ingest Management)

@elasticmachine
Copy link
Collaborator

elasticmachine commented Jul 20, 2020 •
edited by jenkins-beats-ci bot
Loading

💚 Build Succeeded

Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: [Pull request #20076 updated]

  • Start Time: 2020-07-20T19:56:39.938+0000

  • Duration: 31 min 52 sec

michalpristas
michalpristas approved these changes Jul 22, 2020
View reviewed changes
Copy link
Contributor

@michalpristas michalpristas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks ok

@blakerouse blakerouse merged commit c4010d9 into elastic:master Jul 22, 2020
@blakerouse blakerouse mentioned this pull request Jul 22, 2020
Merged
4 tasks
blakerouse added a commit to blakerouse/beats that referenced this pull request Jul 22, 2020
@blakerouse
[Elastic Agent] Add event.dataset to all events (elastic#20076)
b995e2e 
* Inject add_fields event.dataset along side dataset.

* Add event.dataset to all published events.

* Add changelog.

(cherry picked from commit c4010d9)
@blakerouse blakerouse deleted the agent-event-dataset branch July 22, 2020 13:24
blakerouse added a commit to blakerouse/beats that referenced this pull request Jul 22, 2020
@blakerouse
[Elastic Agent] Add event.dataset to all events (elastic#20076)
b791be6 
* Inject add_fields event.dataset along side dataset.

* Add event.dataset to all published events.

* Add changelog.

(cherry picked from commit c4010d9)
@blakerouse blakerouse mentioned this pull request Jul 22, 2020
Merged
4 tasks
blakerouse added a commit that referenced this pull request Jul 22, 2020
@blakerouse
[Elastic Agent] Add event.dataset to all events (#20076) (#20136)
89f39ae 
* Inject add_fields event.dataset along side dataset.

* Add event.dataset to all published events.

* Add changelog.

(cherry picked from commit c4010d9)
blakerouse added a commit that referenced this pull request Jul 22, 2020
@blakerouse
[Elastic Agent] Add event.dataset to all events (#20076) (#20137)
b7c8acc 
* Inject add_fields event.dataset along side dataset.

* Add event.dataset to all published events.

* Add changelog.

(cherry picked from commit c4010d9)
melchiormoulin pushed a commit to melchiormoulin/beats that referenced this pull request Oct 14, 2020
@blakerouse @melchiormoulin
[Elastic Agent] Add event.dataset to all events (elastic#20076)
5acd447 
* Inject add_fields event.dataset along side dataset.

* Add event.dataset to all published events.

* Add changelog.
@andrewkroh andrewkroh mentioned this pull request Jun 2, 2021
Closed
leweafan pushed a commit to leweafan/beats that referenced this pull request Apr 28, 2023
@blakerouse
[Elastic Agent] Add event.dataset to all events (elastic#20076) (elas…
9bed6a5 
…tic#20137)

* Inject add_fields event.dataset along side dataset.

* Add event.dataset to all published events.

* Add changelog.

(cherry picked from commit c231090)
This was referenced Aug 3, 2023
Merged
Open
@tetianakravchenko tetianakravchenko mentioned this pull request Sep 5, 2023
Merged
4 tasks
This was referenced Dec 28, 2023
Closed
Merged
@tetianakravchenko tetianakravchenko mentioned this pull request Apr 9, 2024
Merged
4 tasks
@tetianakravchenko tetianakravchenko mentioned this pull request Nov 8, 2024
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michalpristas michalpristas michalpristas approved these changes

@ph ph ph approved these changes

Assignees

@blakerouse blakerouse

Labels
v7.9.0 v7.10.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Elastic Agent] Should add event.dataset to the logs and metric collected by the agent
4 participants
@blakerouse @elasticmachine @ph @michalpristas