Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[docker] use ecs definition of the 'event.dataset' field for container_logs #11672

Merged
merged 4 commits into from
Nov 12, 2024
Merged

[docker] use ecs definition of the 'event.dataset' field for container_logs #11672

merged 4 commits into from
Nov 12, 2024

Conversation

tetianakravchenko
Copy link
Contributor

Proposed commit message

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.
  • I have verified that any added dashboard complies with Kibana's Dashboard good practices

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Screenshots

@tetianakravchenko tetianakravchenko requested a review from a team as a code owner November 8, 2024 11:22
@tetianakravchenko
change pr link; fix field description
723bc8a 
Signed-off-by: Tetiana Kravchenko <[email protected]>
@andrewkroh andrewkroh added enhancement New feature or request Integration:docker Docker Team:Cloudnative-Monitoring Label for the Cloud Native Monitoring team [elastic/obs-cloudnative-monitoring] labels Nov 8, 2024
@tetianakravchenko
Copy link
Contributor Author

@MichaelKatsoulis @gizas can you please review this PR?

MichaelKatsoulis
MichaelKatsoulis reviewed Nov 12, 2024
View reviewed changes
packages/docker/data_stream/container_logs/agent/stream/stream.yml.hbs Outdated
{{/if}}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No need for the extra line

@tetianakravchenko
remove empty line
f3bc876 
Signed-off-by: Tetiana Kravchenko <[email protected]>
@tetianakravchenko
Copy link
Contributor Author

/test

@elasticmachine
Copy link

💚 Build Succeeded

History

@elastic-sonarqube Elastic SonarQube
Copy link

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
90.5% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube

@tetianakravchenko tetianakravchenko merged commit 9883702 into elastic:main Nov 12, 2024
5 checks passed
@tetianakravchenko tetianakravchenko deleted the docker-dataset-name branch November 12, 2024 14:50
@elastic-vault-github-plugin-prod
Copy link

Package docker - 2.12.0 containing this change is available at https://epr.elastic.co/package/docker/2.12.0/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MichaelKatsoulis MichaelKatsoulis MichaelKatsoulis approved these changes

@gizas gizas Awaiting requested review from gizas gizas is a code owner automatically assigned from elastic/obs-cloudnative-monitoring

Assignees
No one assigned
Labels
enhancement New feature or request Integration:docker Docker Team:Cloudnative-Monitoring Label for the Cloud Native Monitoring team [elastic/obs-cloudnative-monitoring]
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@tetianakravchenko @elasticmachine @MichaelKatsoulis @andrewkroh