Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Azure] azure.eventhub: use ecs definition of the event.dataset field #9554

Merged
merged 2 commits into from
Apr 12, 2024
Merged

[Azure] azure.eventhub: use ecs definition of the event.dataset field #9554

merged 2 commits into from
Apr 12, 2024

Conversation

tetianakravchenko
Copy link
Contributor

@tetianakravchenko tetianakravchenko commented Apr 9, 2024 •
edited
Loading

Proposed commit message

  • WHAT: Use ecs definition of the 'event.dataset' field
  • WHY: there is no need to set event.dataset explicitly - this should be done on the elastic-agent side [Elastic Agent] Add event.dataset to all events beats#20076.
    due to the existence of predefined value, there can happen error, that cause documents dropping

This PR is similar to - #7667

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Screenshots

@tetianakravchenko tetianakravchenko requested review from a team as code owners April 9, 2024 15:05
@elasticmachine
Copy link

🚀 Benchmarks report

To see the full report comment with /test benchmark fullreport

@elasticmachine
Copy link

💚 Build Succeeded

@elastic-sonarqube Elastic SonarQube
Copy link

Quality Gate passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No Coverage information No data about Coverage
No Duplication information No data about Duplication

See analysis details on SonarQube

zmoog
zmoog approved these changes Apr 9, 2024
View reviewed changes
Copy link
Contributor

@zmoog zmoog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

ishleenk17
ishleenk17 approved these changes Apr 12, 2024
View reviewed changes
Copy link
Contributor

@ishleenk17 ishleenk17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for addressing the review

@tetianakravchenko tetianakravchenko merged commit 5fc4e25 into elastic:main Apr 12, 2024
5 checks passed
@tetianakravchenko tetianakravchenko deleted the azure-dataset-name branch April 12, 2024 09:47
@elasticmachine
Copy link

Package azure - 1.11.0 containing this change is available at https://epr.elastic.co/search?package=azure

@andrewkroh andrewkroh added the Integration:azure Azure Logs label Jul 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ishleenk17 ishleenk17 ishleenk17 approved these changes

@zmoog zmoog zmoog approved these changes

Assignees
No one assigned
Labels
Integration:azure Azure Logs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@tetianakravchenko @elasticmachine @zmoog @ishleenk17 @andrewkroh