Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cherry-pick #20076 to 7.9: [Elastic Agent] Add event.dataset to all events #20137

Merged
merged 1 commit into from
Jul 22, 2020
Merged

Cherry-pick #20076 to 7.9: [Elastic Agent] Add event.dataset to all events #20137

merged 1 commit into from
Jul 22, 2020

Conversation

blakerouse
Copy link
Contributor

Cherry-pick of PR #20076 to 7.9 branch. Original message:

What does this PR do?

Adds event.dataset to match the same as dataset.name from the event. This is done on all configurations, even the sidecar monitoring beats.

Why is it important?

So published events do not prevent other features from working in Kibana and ML.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • [ ] I have made corresponding changes to the documentation
  • [ ] I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

How to test this PR locally

Run elastic-agent ensure that all events published to elasticsearch have event.dataset that matches the dataset.name.

Related issues

@blakerouse
[Elastic Agent] Add event.dataset to all events (elastic#20076)
b791be6 
* Inject add_fields event.dataset along side dataset.

* Add event.dataset to all published events.

* Add changelog.

(cherry picked from commit c4010d9)
@elasticmachine
Copy link
Collaborator

Pinging @elastic/ingest-management (Team:Ingest Management)

@botelastic botelastic bot added needs_team Indicates that the issue/PR needs a Team:* label and removed needs_team Indicates that the issue/PR needs a Team:* label labels Jul 22, 2020
@blakerouse blakerouse self-assigned this Jul 22, 2020
michalpristas
michalpristas approved these changes Jul 22, 2020
View reviewed changes
Copy link
Contributor

@michalpristas michalpristas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@blakerouse blakerouse merged commit b7c8acc into elastic:7.9 Jul 22, 2020
@blakerouse blakerouse deleted the backport_20076_7.9 branch July 22, 2020 14:02
@elasticmachine
Copy link
Collaborator

💚 Build Succeeded

Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: [Pull request #20137 opened]

  • Start Time: 2020-07-22T13:25:04.477+0000

  • Duration: 39 min 24 sec

Steps errors

Expand to view the steps failures

  • Name: Install Go 1.14.4

    • Description: .ci/scripts/install-go.sh

    • Duration: 1 min 8 sec

    • Start Time: 2020-07-22T13:48:43.566+0000

    • log

leweafan pushed a commit to leweafan/beats that referenced this pull request Apr 28, 2023
@blakerouse
[Elastic Agent] Add event.dataset to all events (elastic#20076) (elas…
9bed6a5 
…tic#20137)

* Inject add_fields event.dataset along side dataset.

* Add event.dataset to all published events.

* Add changelog.

(cherry picked from commit c231090)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michalpristas michalpristas michalpristas approved these changes

Assignees

@blakerouse blakerouse

Labels
backport [zube]: In Review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@blakerouse @elasticmachine @michalpristas