Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DONOTMERGE] Introduce ADBS Resource and Data Source #4

Open
wants to merge 477 commits into
base: introduce-vm-cluster-resource-and-data-source
Choose a base branch
from

Conversation

eelhomsi
Copy link
Owner

@eelhomsi eelhomsi commented Aug 23, 2024

Community Note

  • Please vote on this PR by adding a 👍 reaction to the original PR to help the community and maintainers prioritize for review
  • Please do not leave comments along the lines of "+1", "me too" or "any updates", they generate extra noise for PR followers and do not help prioritize for review

Description

PRE-REVIEW - PLEASE DO NOT MERGE

Introduce OracleDatabase ADBS Resource & Data source
Most relevant changes in:
internal/services/oracledatabase/

PR Checklist

  • I have followed the guidelines in our Contributing Documentation.
  • I have checked to ensure there aren't other open Pull Requests for the same update/change.
  • I have checked if my changes close any open issues. If so please include appropriate closing keywords below.
  • I have updated/added Documentation as required written in a helpful and kind way to assist users that may be unfamiliar with the resource / data source.
  • I have used a meaningful PR title to help maintainers and other users understand this change and help prevent duplicate work.
    For example: “resource_name_here - description of change e.g. adding property new_property_name_here

Testing

  • My submission includes Test coverage as described in the Contribution Guide and the tests pass. (if this is not possible for any reason, please include details of why you did or could not add test coverage)

Test evidence:
Screenshot 2024-09-05 at 12 28 20
Screenshot 2024-09-05 at 10 10 19
Screenshot 2024-09-04 at 17 28 15
Screenshot 2024-09-04 at 16 38 26

Change Log

Below please provide what should go into the changelog (if anything) conforming to the Changelog Format documented here.

  • FEATURES - Introduced new AutonomousDatabaseCloneDataSource, AutonomousDatabaseRegularDataSource, AdbsCloneResource, and AdbsRegularResource`.

This is a (please select all that apply):

  • Bug Fix
  • New Feature (ie adding a service, resource, or data source)
  • Enhancement
  • Breaking Change

Note

If this PR changes meaningfully during the course of review please update the title and description as required.

teowa and others added 30 commits September 19, 2024 14:58
…ion_enabled` property in tests (hashicorp#27211)

* fix tests for monitor prometheus

* skip log profile test

* fix doc

* recover skipping log profile test
…#27395)

* Document new SKU on NGINXaaS

* Change NGINXaaS SKU to standardv2_Monthly

NGINXaaS now supports a newer SKU
`standardv2_Monthly` and the `standard_Monthly`
SKU has been deprecated.

This change updates the acceptance tests to use
the new SKU.

* Drop possible SKU value fron NGINXaaS datasource

The data source documentation does not need to
tell the user for the possible values of a field
as it is not an input and the user will see the
value once they run the datasource itself.

* Update docs with new NGINXaaS SKU

With the deprecation of standard_Monthly SKU, we
want users to start using the new
`standardv2_Monthly` SKU while we work on retiring
the old one. With that in mind, we'd like our
users to see just latest supported SKUs.
* remove 4.0 flag

* remove unused

* go mod vendor
* Azure CLI authentication update

* Update website/docs/guides/azure_cli.html.markdown

---------

Co-authored-by: kt <[email protected]>
* support vmss zone update

* resolve comments
* new resource stack_hci_deployment_setting

* delete customlocation & arc bridge

* delete arc bridge before custom location

* terrafmt

* fix import test

* disable network direct in acctest

* rename override properties

* disable network direct in test

* doc: elaborate on eu_location_enabled

* change expand/flatten func name first char to lowercase

* setID before create

* fix test exist func

* remove feature toggle

* add notes on additional resources

* add more validations

* fix build issue
* new resource stack_hci_storage_path

* add doc

* add name validation; update test

* setID after poll

* update code

* fix conflict

* update test code style

* fix pre-test env check
…erver` (hashicorp#26955)

* New Resource: azurerm_data_protection_backup_policy_mysql_flexible_server

* update code

* add validate for timezone

* add validation for backup_repeating_time_intervals
…shicorp#27396)

* `azurerm_container_app` - Relax validation on the ingress traffic

* Update doc

* pass golint

* pass golint
teowa and others added 30 commits October 22, 2024 11:24
Co-authored-by: hashicorp-tsccr[bot] <hashicorp-tsccr[bot]@users.noreply.github.com>
…p#27694)

* fix acctest failed with replace in firewall

* remove fixed location of fw policy test which may cause replace
Added note that default_desktop_display_name is required in order to connect to a virtual desktop via Windows 365 portal.
…to introduce-adbs-data-resource

# Conflicts:
#	website/docs/d/oracle_autonomous_database_regular.html.markdown
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.