forked from hashicorp/terraform-provider-azurerm
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DONOTMERGE] Introduce ADBS Resource and Data Source #4
Open
eelhomsi
wants to merge
477
commits into
introduce-vm-cluster-resource-and-data-source
Choose a base branch
from
introduce-adbs-data-resource
base: introduce-vm-cluster-resource-and-data-source
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
[DONOTMERGE] Introduce ADBS Resource and Data Source #4
eelhomsi
wants to merge
477
commits into
introduce-vm-cluster-resource-and-data-source
from
introduce-adbs-data-resource
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ion_enabled` property in tests (hashicorp#27211) * fix tests for monitor prometheus * skip log profile test * fix doc * recover skipping log profile test
…ature flag and update documents (hashicorp#27370)
…#27395) * Document new SKU on NGINXaaS * Change NGINXaaS SKU to standardv2_Monthly NGINXaaS now supports a newer SKU `standardv2_Monthly` and the `standard_Monthly` SKU has been deprecated. This change updates the acceptance tests to use the new SKU. * Drop possible SKU value fron NGINXaaS datasource The data source documentation does not need to tell the user for the possible values of a field as it is not an input and the user will see the value once they run the datasource itself. * Update docs with new NGINXaaS SKU With the deprecation of standard_Monthly SKU, we want users to start using the new `standardv2_Monthly` SKU while we work on retiring the old one. With that in mind, we'd like our users to see just latest supported SKUs.
bump golangci-lint-action to 6.1.0
* remove 4.0 flag * remove unused * go mod vendor
…s` when `sku` is `Basic` (hashicorp#27420)
* Azure CLI authentication update * Update website/docs/guides/azure_cli.html.markdown --------- Co-authored-by: kt <[email protected]>
* support vmss zone update * resolve comments
* new resource stack_hci_deployment_setting * delete customlocation & arc bridge * delete arc bridge before custom location * terrafmt * fix import test * disable network direct in acctest * rename override properties * disable network direct in test * doc: elaborate on eu_location_enabled * change expand/flatten func name first char to lowercase * setID before create * fix test exist func * remove feature toggle * add notes on additional resources * add more validations * fix build issue
Signed-off-by: Jan-Otto Kröpke <[email protected]>
* new resource stack_hci_storage_path * add doc * add name validation; update test * setID after poll * update code * fix conflict * update test code style * fix pre-test env check
…erver` (hashicorp#26955) * New Resource: azurerm_data_protection_backup_policy_mysql_flexible_server * update code * add validate for timezone * add validation for backup_repeating_time_intervals
…shicorp#27396) * `azurerm_container_app` - Relax validation on the ingress traffic * Update doc * pass golint * pass golint
* remove 4.0 flag * fix
Co-authored-by: hashicorp-tsccr[bot] <hashicorp-tsccr[bot]@users.noreply.github.com>
…#27714) * fix short term retention update * fix typo
…p#27694) * fix acctest failed with replace in firewall * remove fixed location of fw policy test which may cause replace
Added note that default_desktop_display_name is required in order to connect to a virtual desktop via Windows 365 portal.
…to introduce-adbs-data-resource # Conflicts: # website/docs/d/oracle_autonomous_database_regular.html.markdown
…e-adbs-data-resource
Co-authored-by: stephybun <[email protected]>
Co-authored-by: stephybun <[email protected]>
Co-authored-by: stephybun <[email protected]>
…to introduce-adbs-data-resource
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Community Note
Description
PRE-REVIEW - PLEASE DO NOT MERGE
Introduce OracleDatabase ADBS Resource & Data source
Most relevant changes in:
internal/services/oracledatabase/
PR Checklist
For example: “
resource_name_here
- description of change e.g. adding propertynew_property_name_here
”Testing
Test evidence:
Change Log
Below please provide what should go into the changelog (if anything) conforming to the Changelog Format documented here.
AutonomousDatabaseCloneDataSource,
AutonomousDatabaseRegularDataSource,
AdbsCloneResource, and
AdbsRegularResource`.This is a (please select all that apply):
Note
If this PR changes meaningfully during the course of review please update the title and description as required.