`VMSS` - Support updating `zones` #27288

ms-zhenhua · 2024-09-05T07:56:06Z

Community Note

Please vote on this PR by adding a 👍 reaction to the original PR to help the community and maintainers prioritize for review
Please do not leave comments along the lines of "+1", "me too" or "any updates", they generate extra noise for PR followers and do not help prioritize for review

Description

Support updating zones field in azurerm_linux_virtual_machine_scale_set, azurerm_orchestrated_virtual_machine_scale_set and azurerm_windows_virtual_machine_scale_set.

PR Checklist

I have followed the guidelines in our Contributing Documentation.
I have checked to ensure there aren't other open Pull Requests for the same update/change.
I have checked if my changes close any open issues. If so please include appropriate closing keywords below.
I have updated/added Documentation as required written in a helpful and kind way to assist users that may be unfamiliar with the resource / data source.
I have used a meaningful PR title to help maintainers and other users understand this change and help prevent duplicate work.
For example: “resource_name_here - description of change e.g. adding property new_property_name_here”

Changes to existing Resource / Data Source

I have added an explanation of what my changes do and why I'd like you to include them (This may be covered by linking to an issue above, but may benefit from additional explanation).
I have written new tests for my resource or datasource changes & updated any relevent documentation.
I have successfully run tests with my changes locally. If not, please provide details on testing challenges that prevented you running the tests.
(For changes that include a state migration only). I have manually tested the migration path between relevant versions of the provider.

Testing

My submission includes Test coverage as described in the Contribution Guide and the tests pass. (if this is not possible for any reason, please include details of why you did or could not add test coverage)

--- PASS: TestAccOrchestratedVirtualMachineScaleSet_zoneUpdate (342.49s)
--- PASS: TestAccWindowsVirtualMachineScaleSet_scalingZonesUpdate (940.20s)
--- PASS: TestAccLinuxVirtualMachineScaleSet_scalingZonesUpdate (1305.01s)
PASS
ok github.com/hashicorp/terraform-provider-azurerm/internal/services/compute 1340.901s

Change Log

Below please provide what should go into the changelog (if anything) conforming to the Changelog Format documented here.

VMSS - Support updating zones

This is a (please select all that apply):

Bug Fix
New Feature (ie adding a service, resource, or data source)
Enhancement
Breaking Change

Related Issue(s)

Fixes #0000

Note

If this PR changes meaningfully during the course of review please update the title and description as required.

mbfrahry

Hey @ms-zhenhua, thanks for this! Just updating the wording on the docs and wondering if we need to do the third test step for this change

mbfrahry · 2024-09-06T22:37:12Z

website/docs/r/linux_virtual_machine_scale_set.html.markdown

-* `zones` - (Optional) Specifies a list of Availability Zones in which this Linux Virtual Machine Scale Set should be located. Changing this forces a new Linux Virtual Machine Scale Set to be created.
+* `zones` - (Optional) Specifies a list of Availability Zones in which this Linux Virtual Machine Scale Set should be located.
+
+-> **Note:** Removing existing zones from existing Virtual Machine Scale Set is currently not supported.


Suggested change

-> **Note:** Removing existing zones from existing Virtual Machine Scale Set is currently not supported.

-> **Note:** Updating `zones` to remove an existing zone forces a new Virtual Machine Scale Set to be created.

Updated. Thanks.

mbfrahry · 2024-09-06T22:37:21Z

website/docs/r/orchestrated_virtual_machine_scale_set.html.markdown

-* `zones` - (Optional) Specifies a list of Availability Zones across which the Virtual Machine Scale Set will create instances. Changing this forces a new Virtual Machine Scale Set to be created.
+* `zones` - (Optional) Specifies a list of Availability Zones across which the Virtual Machine Scale Set will create instances.
+
+-> **Note:** Removing existing zones from existing Virtual Machine Scale Set is currently not supported.


Suggested change

-> **Note:** Removing existing zones from existing Virtual Machine Scale Set is currently not supported.

-> **Note:** Updating `zones` to remove an existing zone forces a new Virtual Machine Scale Set to be created.

Updated. Thanks.

mbfrahry · 2024-09-06T22:37:26Z

website/docs/r/windows_virtual_machine_scale_set.html.markdown

-* `zones` - (Optional) Specifies a list of Availability Zones in which this Windows Virtual Machine Scale Set should be located. Changing this forces a new Windows Virtual Machine Scale Set to be created.
+* `zones` - (Optional) Specifies a list of Availability Zones in which this Windows Virtual Machine Scale Set should be located.
+
+-> **Note:** Removing existing zones from existing Virtual Machine Scale Set is currently not supported.


Suggested change

-> **Note:** Removing existing zones from existing Virtual Machine Scale Set is currently not supported.

-> **Note:** Updating `zones` to remove an existing zone forces a new Virtual Machine Scale Set to be created.

Updated. Thanks.

mbfrahry · 2024-09-06T22:41:33Z

internal/services/compute/windows_virtual_machine_scale_set_resource_scaling_test.go

+		},
+		data.ImportStep("admin_password"),
+		{
+			Config: r.scalingZonesSingle(data),


My understanding is that we can add new zones but can't remove existing zones, so will this step recreate the resource? If so, we shouldn't have this step

You're correct. It will recreate the resource. I have removed this step. Thanks.

mbfrahry · 2024-09-06T22:41:48Z

internal/services/compute/orchestrated_virtual_machine_scale_set_resource_other_test.go

+			),
+		},
+		{
+			Config: r.singleZone(data),


My understanding is that we can add new zones but can't remove existing zones, so will this step recreate the resource? If so, we shouldn't have this step

You're correct. It will recreate the resource. I have removed this step. Thanks.

mbfrahry · 2024-09-06T22:41:55Z

internal/services/compute/linux_virtual_machine_scale_set_resource_scaling_test.go

+		},
+		data.ImportStep("admin_password"),
+		{
+			Config: r.scalingZonesSingle(data),


My understanding is that we can add new zones but can't remove existing zones, so will this step recreate the resource? If so, we shouldn't have this step

You're correct. It will recreate the resource. I have removed this step. Thanks.

ms-zhenhua · 2024-09-09T02:44:45Z

Hi @mbfrahry,

Thank you for your review. I have updated the code. Please kindly take another review.

fitzgeraldsteele · 2024-09-16T22:46:30Z

👍🏾

fitzgeraldsteele · 2024-09-16T23:35:21Z

@mbfrahry thanks for the review! Please let us know if there are any issues remaining! Would love to make the deployment train this week

katbyte

LGTM 🍒

github-actions · 2024-10-20T02:16:28Z

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

support vmss zone update

b6477fc

github-actions bot added documentation size/L labels Sep 5, 2024

ms-zhenhua marked this pull request as ready for review September 5, 2024 08:37

mbfrahry requested changes Sep 6, 2024

View reviewed changes

github-actions bot added the waiting-response label Sep 6, 2024

resolve comments

14995ce

github-actions bot removed the waiting-response label Sep 9, 2024

ms-zhenhua requested a review from mbfrahry September 9, 2024 02:44

katbyte approved these changes Sep 19, 2024

View reviewed changes

katbyte merged commit 9c2cc02 into hashicorp:main Sep 19, 2024
39 checks passed

github-actions bot added this to the v4.3.0 milestone Sep 19, 2024

katbyte added a commit that referenced this pull request Sep 19, 2024

Update CHANGELOG.md #27288

17f7e51

github-actions bot locked as resolved and limited conversation to collaborators Oct 20, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

`VMSS` - Support updating `zones` #27288

`VMSS` - Support updating `zones` #27288

ms-zhenhua commented Sep 5, 2024 •

edited

Loading

mbfrahry left a comment

mbfrahry Sep 6, 2024

ms-zhenhua Sep 9, 2024

mbfrahry Sep 6, 2024

ms-zhenhua Sep 9, 2024

mbfrahry Sep 6, 2024

ms-zhenhua Sep 9, 2024

mbfrahry Sep 6, 2024

ms-zhenhua Sep 9, 2024

mbfrahry Sep 6, 2024

ms-zhenhua Sep 9, 2024

mbfrahry Sep 6, 2024

ms-zhenhua Sep 9, 2024

ms-zhenhua commented Sep 9, 2024

fitzgeraldsteele commented Sep 16, 2024

fitzgeraldsteele commented Sep 16, 2024

katbyte left a comment

github-actions bot commented Oct 20, 2024

	-> Note: Removing existing zones from existing Virtual Machine Scale Set is currently not supported.
	-> Note: Updating `zones` to remove an existing zone forces a new Virtual Machine Scale Set to be created.

VMSS - Support updating zones #27288

VMSS - Support updating zones #27288

Conversation

ms-zhenhua commented Sep 5, 2024 • edited Loading

Community Note

Description

PR Checklist

Changes to existing Resource / Data Source

Testing

Change Log

Related Issue(s)

mbfrahry left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ms-zhenhua commented Sep 9, 2024

fitzgeraldsteele commented Sep 16, 2024

fitzgeraldsteele commented Sep 16, 2024

katbyte left a comment

Choose a reason for hiding this comment

github-actions bot commented Oct 20, 2024

`VMSS` - Support updating `zones` #27288

`VMSS` - Support updating `zones` #27288

ms-zhenhua commented Sep 5, 2024 •

edited

Loading