Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

azure_nginx_deployment: Use the standardv2_Monthly SKU #27395

Merged
merged 4 commits into from
Sep 19, 2024
Merged

azure_nginx_deployment: Use the standardv2_Monthly SKU #27395

merged 4 commits into from
Sep 19, 2024

Conversation

puneetsarna
Copy link
Contributor

@puneetsarna puneetsarna commented Sep 14, 2024 •
edited
Loading

Community Note

  • Please vote on this PR by adding a 👍 reaction to the original PR to help the community and maintainers prioritize for review
  • Please do not leave comments along the lines of "+1", "me too" or "any updates", they generate extra noise for PR followers and do not help prioritize for review

Description

PR Checklist

  • I have followed the guidelines in our Contributing Documentation.
  • I have checked to ensure there aren't other open Pull Requests for the same update/change.
  • I have checked if my changes close any open issues. If so please include appropriate closing keywords below.
  • I have updated/added Documentation as required written in a helpful and kind way to assist users that may be unfamiliar with the resource / data source.
  • I have used a meaningful PR title to help maintainers and other users understand this change and help prevent duplicate work.
    For example: “resource_name_here - description of change e.g. adding property new_property_name_here”

Changes to existing Resource / Data Source

  • I have added an explanation of what my changes do and why I'd like you to include them (This may be covered by linking to an issue above, but may benefit from additional explanation).
  • I have written new tests for my resource or datasource changes & updated any relevent documentation.
  • I have successfully run tests with my changes locally. If not, please provide details on testing challenges that prevented you running the tests.
  • (For changes that include a state migration only). I have manually tested the migration path between relevant versions of the provider.

Testing

  • My submission includes Test coverage as described in the Contribution Guide and the tests pass. (if this is not possible for any reason, please include details of why you did or could not add test coverage)

Change Log

Below please provide what should go into the changelog (if anything) conforming to the Changelog Format documented here.

  • azurerm_resource - support for the thing1 property [GH-00000]

This is a (please select all that apply):

  • Bug Fix
  • New Feature (ie adding a service, resource, or data source)
  • Enhancement
  • Breaking Change

Related Issue(s)

Fixes #0000

Note

If this PR changes meaningfully during the course of review please update the title and description as required.

@puneetsarna
Document new SKU on NGINXaaS
6c12292
@puneetsarna
Change NGINXaaS SKU to standardv2_Monthly
ab90090 
NGINXaaS now supports a newer SKU
`standardv2_Monthly` and the `standard_Monthly`
SKU has been deprecated.

This change updates the acceptance tests to use
the new SKU.
@puneetsarna
Drop possible SKU value fron NGINXaaS datasource
420ae0d 
The data source documentation does not need to
tell the user for the possible values of a field
as it is not an input and the user will see the
value once they run the datasource itself.
@puneetsarna
Update docs with new NGINXaaS SKU
7538a1f 
With the deprecation of standard_Monthly SKU, we
want users to start using the new
`standardv2_Monthly` SKU while we work on retiring
the old one. With that in mind, we'd like our
users to see just latest supported SKUs.
@puneetsarna puneetsarna mentioned this pull request Sep 14, 2024
Closed
14 tasks
@puneetsarna
Copy link
Contributor Author

@stephybun @katbyte

@puneetsarna puneetsarna changed the title NGINXaaS: Use the standardv2_Monthly SKU azure_nginx_deployment: Use the standardv2_Monthly SKU Sep 17, 2024
katbyte
katbyte approved these changes Sep 19, 2024
View reviewed changes
Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ♻️

@katbyte katbyte merged commit 7424b45 into hashicorp:main Sep 19, 2024
34 checks passed
@github-actions github-actions bot added this to the v4.3.0 milestone Sep 19, 2024
@github-actions GitHub Actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 20, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@katbyte katbyte katbyte approved these changes

@ornj ornj ornj approved these changes

@ryepup ryepup ryepup approved these changes

Assignees
No one assigned
Labels
documentation service/nginx size/XS
Projects
None yet
Milestone
v4.3.0
Development

Successfully merging this pull request may close these issues.
4 participants
@puneetsarna @ryepup @ornj @katbyte