Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

firewall: remove or updat acctests contains replace cases #27694

Merged
merged 2 commits into from
Oct 22, 2024
Merged

firewall: remove or updat acctests contains replace cases #27694

merged 2 commits into from
Oct 22, 2024

Conversation

wuxu92
Copy link
Contributor

@wuxu92 wuxu92 commented Oct 18, 2024 •
edited
Loading

Description

Draft for test in TC

image

Test Result:
image

--- PASS: TestAccFirewallPolicyRuleCollectionGroup_updatePremium (276.47s)
--- PASS: TestAccFirewall_enableDNS (1634.05s)

@wuxu92 wuxu92 marked this pull request as ready for review October 18, 2024 12:34
@wuxu92 wuxu92 requested review from katbyte and a team as code owners October 18, 2024 12:34
stephybun
stephybun approved these changes Oct 22, 2024
View reviewed changes
Copy link
Member

@stephybun stephybun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @wuxu92 LGTM 👍

@stephybun stephybun merged commit 65a204f into hashicorp:main Oct 22, 2024
29 checks passed
@github-actions github-actions bot added this to the v4.7.0 milestone Oct 22, 2024
@github-actions GitHub Actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 22, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@stephybun stephybun stephybun approved these changes

@katbyte katbyte Awaiting requested review from katbyte

Assignees
No one assigned
Labels
enhancement service/firewall size/XS tests
Projects
None yet
Milestone
v4.7.0
Development

Successfully merging this pull request may close these issues.
3 participants
@wuxu92 @stephybun @rcskosir