Ignore includeAllVersions if extensionVersion is specified. #421
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@amvanbaren Tested this, LGTM 👍 |
This was referenced Apr 4, 2022
amvanbaren
added a commit
to EclipseFdn/open-vsx.org
that referenced
this pull request
May 22, 2022
eclipse/openvsx#457 eclipse/openvsx#434 eclipse/openvsx#429 eclipse/openvsx#443 eclipse/openvsx#435 eclipse/openvsx#442 eclipse/openvsx#406 eclipse/openvsx#433 eclipse/openvsx#424 [feat: Add support for X-Forwarded-Prefix](eclipse/openvsx@ea2cde9) eclipse/openvsx#419 eclipse/openvsx#421 eclipse/openvsx#422 eclipse/openvsx#410 Dependabot updates: [Bump ajv from 6.12.2 to 6.12.6 in /webui](eclipse/openvsx@f475efa) [Bump follow-redirects from 1.14.7 to 1.14.8 in /cli](eclipse/openvsx@4f8445c) [Bump pathval from 1.1.0 to 1.1.1 in /webui](eclipse/openvsx@a477256) [Bump simple-get from 3.1.0 to 3.1.1 in /cli](eclipse/openvsx@2a2d537)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes bug introduced by #357
param.includeAllVersionswas only used here:https://github.com/amvanbaren/openvsx/blob/181346853fe636cb171321a69a1a161f286dbd27/server/src/main/java/org/eclipse/openvsx/LocalRegistryService.java#L269-L281
when
param.extensionVersionis specified, thenhttps://github.com/amvanbaren/openvsx/blob/181346853fe636cb171321a69a1a161f286dbd27/server/src/main/java/org/eclipse/openvsx/LocalRegistryService.java#L242
is called, skipping the
param.includeAllVersionslogic.#357 changed this to
https://github.com/amvanbaren/openvsx/blob/db776443c68abb08f6649ecaaa5c971d561099f8/server/src/main/java/org/eclipse/openvsx/LocalRegistryService.java#L270
while it should skip this logic if
param.includeAllVersionsis specified.Testing steps:
Call
/api/-/query?namespaceName={namespace}&extensionName={extension}&extensionVersion={version}where{version}isn't the latest version of the extension.Before this change:
response.extensionsis empty array.After this change:
response.extensionscontains extension version.